From: Mark Brown <broonie@kernel.org>
To: Peter Rosin <peda@axentia.se>
Cc: linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Misbah Ullah Khan <Misbahk@danlawinc.com>,
alsa-devel@alsa-project.org, devicetree@vger.kernel.org
Subject: Re: [PATCH v3] ASoC: MAX9860: new driver
Date: Fri, 13 May 2016 11:58:52 +0100 [thread overview]
Message-ID: <20160513105852.GC22038@sirena.org.uk> (raw)
In-Reply-To: <1463124333-9489-1-git-send-email-peda@axentia.se>
[-- Attachment #1: Type: text/plain, Size: 595 bytes --]
On Fri, May 13, 2016 at 09:25:33AM +0200, Peter Rosin wrote:
> +static int max9860_dai_startup(struct snd_pcm_substream *substream,
> + struct snd_soc_dai *dai)
> +{
> + struct snd_soc_codec *codec = dai->codec;
> + struct max9860_priv *max9860 = snd_soc_codec_get_drvdata(codec);
> +
> + switch (max9860->fmt & SND_SOC_DAIFMT_MASTER_MASK) {
> + case SND_SOC_DAIFMT_CBM_CFM:
> + case SND_SOC_DAIFMT_CBS_CFS:
> + return 0;
> +
> + default:
> + return -EINVAL;
> + }
> +}
This isn't the place to enforce restrictions on DAI format, do it in
set_dai_fmt().
Otherwise this looks good.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-05-13 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 7:25 [PATCH v3] ASoC: MAX9860: new driver Peter Rosin
2016-05-13 10:58 ` Mark Brown [this message]
2016-05-16 16:22 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160513105852.GC22038@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Misbahk@danlawinc.com \
--cc=alsa-devel@alsa-project.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=peda@axentia.se \
--cc=perex@perex.cz \
--cc=robh+dt@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox