From: David Miller <davem@davemloft.net>
To: f.fainelli@gmail.com
Cc: rabin.vincent@axis.com, andrew@lunn.ch, netdev@vger.kernel.org,
linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org,
devicetree@vger.kernel.org, rabinv@axis.com
Subject: Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add()
Date: Tue, 17 May 2016 14:30:30 -0400 (EDT) [thread overview]
Message-ID: <20160517.143030.176679255082144481.davem@davemloft.net> (raw)
In-Reply-To: <573B6280.3030405@gmail.com>
From: Florian Fainelli <f.fainelli@gmail.com>
Date: Tue, 17 May 2016 11:27:12 -0700
> On 05/17/2016 11:20 AM, David Miller wrote:
>> From: Rabin Vincent <rabin.vincent@axis.com>
>> Date: Mon, 16 May 2016 13:15:56 +0200
>>
>>> From: Rabin Vincent <rabinv@axis.com>
>>>
>>> Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"),
>>> platforms which call fixed_phy_add() before fixed_mdio_bus_init() is
>>> called (for example, because the platform code and the fixed_phy driver
>>> use the same initcall level) crash in fixed_phy_add() since the
>>> ->mii_bus is not allocated.
>>>
>>> Also since e7f4dc3536a, these interrupts are initalized to polling by
>>> default. All callers of both fixed_phy_register() and fixed_phy_add()
>>> pass PHY_POLL for the irq argument, so we can fix these crashes by
>>> simply removing the irq parameter, since the default is correct for all
>>> users.
>>>
>>> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core")
>>> Signed-off-by: Rabin Vincent <rabinv@axis.com>
>>
>> Applied.
>
> David, there was a v2 sent just earlier this morning here:
>
> http://patchwork.ozlabs.org/patch/622967/
>
> which was appropriately marked with Changes Requested, so why would we
> apply v1?
And that v2 needs changes still.
My bad I'll revert v1, sorry.
prev parent reply other threads:[~2016-05-17 18:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 11:15 [PATCH] phy: remove irq param to fix crash in fixed_phy_add() Rabin Vincent
2016-05-16 12:29 ` Andrew Lunn
[not found] ` <20160516122903.GA27725-g2DYL2Zd6BY@public.gmane.org>
2016-05-16 13:11 ` Rabin Vincent
2016-05-16 13:40 ` Andrew Lunn
2016-05-16 17:26 ` Florian Fainelli
2016-05-17 18:20 ` David Miller
2016-05-17 18:27 ` Florian Fainelli
2016-05-17 18:30 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160517.143030.176679255082144481.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=linux-m68k@lists.linux-m68k.org \
--cc=linux-mips@linux-mips.org \
--cc=netdev@vger.kernel.org \
--cc=rabin.vincent@axis.com \
--cc=rabinv@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).