From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [PATCH] phy: remove irq param to fix crash in fixed_phy_add() Date: Tue, 17 May 2016 14:30:30 -0400 (EDT) Message-ID: <20160517.143030.176679255082144481.davem@davemloft.net> References: <1463397356-5656-1-git-send-email-rabin.vincent@axis.com> <20160517.142034.611823602956859056.davem@davemloft.net> <573B6280.3030405@gmail.com> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <573B6280.3030405@gmail.com> Sender: linux-m68k-owner@vger.kernel.org To: f.fainelli@gmail.com Cc: rabin.vincent@axis.com, andrew@lunn.ch, netdev@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org, devicetree@vger.kernel.org, rabinv@axis.com List-Id: devicetree@vger.kernel.org From: Florian Fainelli Date: Tue, 17 May 2016 11:27:12 -0700 > On 05/17/2016 11:20 AM, David Miller wrote: >> From: Rabin Vincent >> Date: Mon, 16 May 2016 13:15:56 +0200 >> >>> From: Rabin Vincent >>> >>> Since e7f4dc3536a ("mdio: Move allocation of interrupts into core"), >>> platforms which call fixed_phy_add() before fixed_mdio_bus_init() is >>> called (for example, because the platform code and the fixed_phy driver >>> use the same initcall level) crash in fixed_phy_add() since the >>> ->mii_bus is not allocated. >>> >>> Also since e7f4dc3536a, these interrupts are initalized to polling by >>> default. All callers of both fixed_phy_register() and fixed_phy_add() >>> pass PHY_POLL for the irq argument, so we can fix these crashes by >>> simply removing the irq parameter, since the default is correct for all >>> users. >>> >>> Fixes: e7f4dc3536a400 ("mdio: Move allocation of interrupts into core") >>> Signed-off-by: Rabin Vincent >> >> Applied. > > David, there was a v2 sent just earlier this morning here: > > http://patchwork.ozlabs.org/patch/622967/ > > which was appropriately marked with Changes Requested, so why would we > apply v1? And that v2 needs changes still. My bad I'll revert v1, sorry.