From: Rob Herring <robh@kernel.org>
To: Robin van der Gracht <robin@protonic.nl>
Cc: linux-kernel@vger.kernel.org, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Miguel Ojeda Sandonis <miguel.ojeda.sandonis@gmail.com>,
Thierry Reding <treding@nvidia.com>,
Shawn Guo <shawnguo@kernel.org>,
Jonathan Cameron <jic23@kernel.org>,
Matt Ranostay <mranostay@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
"David S . Miller" <davem@davemloft.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kalle Valo <kvalo@codeaurora.org>,
Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
Guenter Roeck <linux@roeck-us.net>, Jiri Slaby <jslaby@suse.com>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v6 2/3] auxdisplay: ht16k33: Driver for LED controller
Date: Wed, 18 May 2016 18:23:00 -0500 [thread overview]
Message-ID: <20160518232300.GA4243@rob-hp-laptop> (raw)
In-Reply-To: <1463574199-21077-3-git-send-email-robin@protonic.nl>
On Wed, May 18, 2016 at 02:23:18PM +0200, Robin van der Gracht wrote:
> Added a driver for the Holtek HT16K33 LED controller with keyscan.
>
> Signed-off-by: Robin van der Gracht <robin@protonic.nl>
> ---
> Changes in v6:
> - Fixed minor typo in documentation 'KEY_F0' -> 'KEY_F10'
>
> .../devicetree/bindings/display/ht16k33.txt | 42 ++
> drivers/auxdisplay/Kconfig | 9 +
> drivers/auxdisplay/Makefile | 1 +
> drivers/auxdisplay/ht16k33.c | 563 +++++++++++++++++++++
> 4 files changed, 615 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/ht16k33.txt
> create mode 100644 drivers/auxdisplay/ht16k33.c
>
> diff --git a/Documentation/devicetree/bindings/display/ht16k33.txt b/Documentation/devicetree/bindings/display/ht16k33.txt
> new file mode 100644
> index 0000000..5c11320
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/ht16k33.txt
> @@ -0,0 +1,42 @@
> +Holtek ht16k33 RAM mapping 16*8 LED controller driver with keyscan
> +-------------------------------------------------------------------------------
> +
> +Required properties:
> +- compatible: "holtek,ht16k33"
> +- reg: I2C slave address of the chip.
> +- interrupt-parent: A phandle pointing to the interrupt controller
> + serving the interrupt for this chip.
> +- interrupts: Interrupt specification for the key pressed interrupt.
> +- refresh-rate-hz: Display update interval in HZ.
> +- debounce-delay-ms: Debouncing interval time in microseconds.
The units and description still don't match.
I acked the last one. Please add acks when sending new versions (unless
of course you don't fix any trivial things noted).
Rob
next prev parent reply other threads:[~2016-05-18 23:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 12:23 [PATCH v6 0/3] auxdisplay: Introduce ht16k33 driver Robin van der Gracht
2016-05-18 12:23 ` [PATCH v6 1/3] of: add vendor prefix for Holtek Semiconductor Robin van der Gracht
[not found] ` <1463574199-21077-2-git-send-email-robin-/Q/L1SwJa3aEVqv0pETR8A@public.gmane.org>
2016-05-18 23:17 ` Rob Herring
2016-05-18 12:23 ` [PATCH v6 2/3] auxdisplay: ht16k33: Driver for LED controller Robin van der Gracht
2016-05-18 23:23 ` Rob Herring [this message]
2016-05-18 12:23 ` [PATCH v6 3/3] MAINTAINERS: auxdisplay: Added myself as maintainer for ht16k33 driver Robin van der Gracht
2016-05-18 14:32 ` Linus Walleij
[not found] ` <1463574199-21077-1-git-send-email-robin-/Q/L1SwJa3aEVqv0pETR8A@public.gmane.org>
2016-05-18 15:09 ` [PATCH v6 0/3] auxdisplay: Introduce " Greg Kroah-Hartman
2016-05-19 8:54 ` Robin van der Gracht
2016-05-19 12:57 ` get_maintainer.pl and MAINTAINERS file Kalle Valo
[not found] ` <871t4yfbmy.fsf_-_-HodKDYzPHsUD5k0oWYwrnHL1okKdlPRT@public.gmane.org>
2016-05-19 14:25 ` Richard Weinberger
[not found] ` <CAFLxGvwU-2aE7_0Suht--DvWby3RT=mdkpRomHz25MgicRfC3w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-05-19 16:57 ` Mauro Carvalho Chehab
2016-05-20 13:14 ` Kalle Valo
2016-05-19 19:53 ` Jiri Slaby
2016-05-19 22:32 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160518232300.GA4243@rob-hp-laptop \
--to=robh@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=gregkh@linuxfoundation.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jic23@kernel.org \
--cc=jslaby@suse.com \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=mchehab@osg.samsung.com \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mranostay@gmail.com \
--cc=pawel.moll@arm.com \
--cc=robin@protonic.nl \
--cc=shawnguo@kernel.org \
--cc=treding@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox