* [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller [not found] ` <1463732875-23141-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2016-05-20 8:27 ` Neil Armstrong [not found] ` <1463732875-23141-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 2016-05-23 21:04 ` Rob Herring 0 siblings, 2 replies; 13+ messages in thread From: Neil Armstrong @ 2016-05-20 8:27 UTC (permalink / raw) To: linux-kernel-u79uwXL29TY76Z2rM5mHXA, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r Cc: Neil Armstrong, xing.xu-LpR1jeaWuhtBDgjK7y7TUQ, victor.wan-LpR1jeaWuhtBDgjK7y7TUQ, jerry.cao-LpR1jeaWuhtBDgjK7y7TUQ, devicetree-u79uwXL29TY76Z2rM5mHXA Add DT bindings for the Meson GXBB SoC Reset Controller documentation and the associated include file. Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> --- .../bindings/reset/amlogic,meson-gxbb-reset.txt | 18 ++ .../dt-bindings/reset/amlogic,meson-gxbb-reset.h | 199 +++++++++++++++++++++ 2 files changed, 217 insertions(+) create mode 100644 Documentation/devicetree/bindings/reset/amlogic,meson-gxbb-reset.txt create mode 100644 include/dt-bindings/reset/amlogic,meson-gxbb-reset.h diff --git a/Documentation/devicetree/bindings/reset/amlogic,meson-gxbb-reset.txt b/Documentation/devicetree/bindings/reset/amlogic,meson-gxbb-reset.txt new file mode 100644 index 0000000..0758259 --- /dev/null +++ b/Documentation/devicetree/bindings/reset/amlogic,meson-gxbb-reset.txt @@ -0,0 +1,18 @@ +Amlogic Meson GXBB SoC Reset Controller +======================================= + +Please also refer to reset.txt in this directory for common reset +controller binding usage. + +Required properties: +- compatible: Should be "amlogic,meson-gxbb-reset" +- reg: should contain the register address base +- #reset-cells: 1, see below + +example: + +reset: reset-controller { + compatible = "amlogic,meson-gxbb-reset"; + reg = <0x0 0x04404 0x0 0x20>; + #reset-cells = <1>; +}; diff --git a/include/dt-bindings/reset/amlogic,meson-gxbb-reset.h b/include/dt-bindings/reset/amlogic,meson-gxbb-reset.h new file mode 100644 index 0000000..ff4e804 --- /dev/null +++ b/include/dt-bindings/reset/amlogic,meson-gxbb-reset.h @@ -0,0 +1,199 @@ +/* + * Copyright (c) 2016 BayLibre, SAS. + * Author: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> + * + * This file is dual-licensed: you can use it either under the terms + * of the GPL or the X11 license, at your option. Note that this dual + * licensing only applies to this file, and not this project as a + * whole. + * + * a) This library is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of the + * License, or (at your option) any later version. + * + * This library is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * Or, alternatively, + * + * b) Permission is hereby granted, free of charge, to any person + * obtaining a copy of this software and associated documentation + * files (the "Software"), to deal in the Software without + * restriction, including without limitation the rights to use, + * copy, modify, merge, publish, distribute, sublicense, and/or + * sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following + * conditions: + * + * The above copyright notice and this permission notice shall be + * included in all copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES + * OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT + * HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, + * WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR + * OTHER DEALINGS IN THE SOFTWARE. + */ + +#ifndef _DT_BINDINGS_AMLOGIC_MESON_GXBB_RESET_H +#define _DT_BINDINGS_AMLOGIC_MESON_GXBB_RESET_H + +/* RESET0 */ +#define RESET_HIU 0 +/* 1 */ +#define RESET_DOS_RESET 2 +#define RESET_DDR_TOP 3 +#define RESET_DCU_RESET 4 +#define RESET_VIU 5 +#define RESET_AIU 6 +#define RESET_VID_PLL_DIV 7 +/* 8 */ +#define RESET_PMUX 9 +#define RESET_VENC 10 +#define RESET_ASSIST 11 +#define RESET_AFIFO2 12 +#define RESET_VCBUS 13 +/* 14 */ +/* 15 */ +#define RESET_GIC 16 +#define RESET_CAPB3_DECODE 17 +#define RESET_NAND_CAPB3 18 +#define RESET_HDMITX_CAPB3 19 +#define RESET_MALI_CAPB3 20 +#define RESET_DOS_CAPB3 21 +#define RESET_SYS_CPU_CAPB3 22 +#define RESET_CBUS_CAPB3 23 +#define RESET_AHB_CNTL 24 +#define RESET_AHB_DATA 25 +#define RESET_VCBUS_CLK81 26 +#define RESET_MMC 27 +#define RESET_MIPI_0 28 +#define RESET_MIPI_1 29 +#define RESET_MIPI_2 30 +#define RESET_MIPI_3 31 +/* RESET1 */ +#define RESET_CPPM 32 +#define RESET_DEMUX 33 +#define RESET_USB_OTG 34 +#define RESET_DDR 35 +#define RESET_AO_RESET 36 +#define RESET_BT656 37 +#define RESET_AHB_SRAM 38 +/* 39 */ +#define RESET_PARSER 40 +#define RESET_BLKMV 41 +#define RESET_ISA 42 +#define RESET_ETHERNET 43 +#define RESET_SD_EMMC_A 44 +#define RESET_SD_EMMC_B 45 +#define RESET_SD_EMMC_C 46 +#define RESET_ROM_BOOT 47 +#define RESET_SYS_CPU_0 48 +#define RESET_SYS_CPU_1 49 +#define RESET_SYS_CPU_2 50 +#define RESET_SYS_CPU_3 51 +#define RESET_SYS_CPU_CORE_0 52 +#define RESET_SYS_CPU_CORE_1 53 +#define RESET_SYS_CPU_CORE_2 54 +#define RESET_SYS_CPU_CORE_3 55 +#define RESET_SYS_PLL_DIV 56 +#define RESET_SYS_CPU_AXI 57 +#define RESET_SYS_CPU_L2 58 +#define RESET_SYS_CPU_P 59 +#define RESET_SYS_CPU_MBIST 60 +/* 61 */ +/* 62 */ +/* 63 */ +/* RESET2 */ +#define RESET_VD_RMEM 64 +#define RESET_AUDIN 65 +#define RESET_HDMI_TX 66 +/* 67 */ +/* 68 */ +/* 69 */ +#define RESET_GE2D 70 +#define RESET_PARSER_REG 71 +#define RESET_PARSER_FETCH 72 +#define RESET_PARSER_CTL 73 +#define RESET_PARSER_TOP 74 +/* 75 */ +/* 76 */ +#define RESET_AO_CPU_RESET 77 +#define RESET_MALI 78 +#define RESET_HDMI_SYSTEM_RESET 79 +/* 80-95 */ +/* RESET3 */ +#define RESET_RING_OSCILLATOR 96 +#define RESET_SYS_CPU 97 +#define RESET_EFUSE 98 +#define RESET_SYS_CPU_BVCI 99 +#define RESET_AIFIFO 100 +#define RESET_TVFE 101 +#define RESET_AHB_BRIDGE_CNTL 102 +/* 103 */ +#define RESET_AUDIO_DAC 104 +#define RESET_DEMUX_TOP 105 +#define RESET_DEMUX_DES 106 +#define RESET_DEMUX_S2P_0 107 +#define RESET_DEMUX_S2P_1 108 +#define RESET_DEMUX_RESET_0 109 +#define RESET_DEMUX_RESET_1 110 +#define RESET_DEMUX_RESET_2 111 +/* 112-127 */ +/* RESET4 */ +/* 128 */ +/* 129 */ +/* 130 */ +/* 131 */ +#define RESET_DVIN_RESET 132 +#define RESET_RDMA 133 +#define RESET_VENCI 134 +#define RESET_VENCP 135 +/* 136 */ +#define RESET_VDAC 137 +#define RESET_RTC 138 +/* 139 */ +#define RESET_VDI6 140 +#define RESET_VENCL 141 +#define RESET_I2C_MASTER_2 142 +#define RESET_I2C_MASTER_1 143 +/* 144-159 */ +/* RESET5 */ +/* 160-191 */ +/* RESET6 */ +#define RESET_PERIPHS_GENERAL 192 +#define RESET_PERIPHS_SPICC 193 +#define RESET_PERIPHS_SMART_CARD 194 +#define RESET_PERIPHS_SAR_ADC 195 +#define RESET_PERIPHS_I2C_MASTER_0 196 +#define RESET_SANA 197 +/* 198 */ +#define RESET_PERIPHS_STREAM_INTERFACE 199 +#define RESET_PERIPHS_SDIO 200 +#define RESET_PERIPHS_UART_0 201 +#define RESET_PERIPHS_UART_1_2 202 +#define RESET_PERIPHS_ASYNC_0 203 +#define RESET_PERIPHS_ASYNC_1 204 +#define RESET_PERIPHS_SPI_0 205 +#define RESET_PERIPHS_SDHC 206 +#define RESET_UART_SLIP 207 +/* 208-223 */ +/* RESET7 */ +#define RESET_USB_DDR_0 224 +#define RESET_USB_DDR_1 225 +#define RESET_USB_DDR_2 226 +#define RESET_USB_DDR_3 227 +/* 228 */ +#define RESET_DEVICE_MMC_ARB 229 +/* 230 */ +#define RESET_VID_LOCK 231 +#define RESET_A9_DMC_PIPEL 232 +/* 233-255 */ + +#endif -- 2.7.0 -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <1463732875-23141-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller [not found] ` <1463732875-23141-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2016-05-20 8:46 ` Carlo Caione 2016-05-20 8:51 ` Neil Armstrong 0 siblings, 1 reply; 13+ messages in thread From: Carlo Caione @ 2016-05-20 8:46 UTC (permalink / raw) To: Neil Armstrong Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, jerry.cao-LpR1jeaWuhtBDgjK7y7TUQ, devicetree-u79uwXL29TY76Z2rM5mHXA, xing.xu-LpR1jeaWuhtBDgjK7y7TUQ, victor.wan-LpR1jeaWuhtBDgjK7y7TUQ On 20/05/16 10:27, Neil Armstrong wrote: > Add DT bindings for the Meson GXBB SoC Reset Controller documentation and the > associated include file. [...] > +#define RESET_I2C_MASTER_2 142 > +#define RESET_I2C_MASTER_1 143 > +/* 144-159 */ > +/* RESET5 */ > +/* 160-191 */ > +/* RESET6 */ > +#define RESET_PERIPHS_GENERAL 192 > +#define RESET_PERIPHS_SPICC 193 > +#define RESET_PERIPHS_SMART_CARD 194 > +#define RESET_PERIPHS_SAR_ADC 195 > +#define RESET_PERIPHS_I2C_MASTER_0 196 > +#define RESET_SANA 197 > +/* 198 */ > +#define RESET_PERIPHS_STREAM_INTERFACE 199 > +#define RESET_PERIPHS_SDIO 200 > +#define RESET_PERIPHS_UART_0 201 > +#define RESET_PERIPHS_UART_1_2 202 > +#define RESET_PERIPHS_ASYNC_0 203 > +#define RESET_PERIPHS_ASYNC_1 204 > +#define RESET_PERIPHS_SPI_0 205 > +#define RESET_PERIPHS_SDHC 206 > +#define RESET_UART_SLIP 207 > +/* 208-223 */ > +/* RESET7 */ > +#define RESET_USB_DDR_0 224 > +#define RESET_USB_DDR_1 225 > +#define RESET_USB_DDR_2 226 > +#define RESET_USB_DDR_3 227 > +/* 228 */ > +#define RESET_DEVICE_MMC_ARB 229 > +/* 230 */ > +#define RESET_VID_LOCK 231 > +#define RESET_A9_DMC_PIPEL 232 > +/* 233-255 */ > + > +#endif Indentation looks really messy. Can you just shift the numbers to the right so that they are on the same column? -- Carlo Caione -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller 2016-05-20 8:46 ` Carlo Caione @ 2016-05-20 8:51 ` Neil Armstrong 2016-05-20 9:08 ` Carlo Caione 0 siblings, 1 reply; 13+ messages in thread From: Neil Armstrong @ 2016-05-20 8:51 UTC (permalink / raw) To: Carlo Caione Cc: linux-kernel, p.zabel, linux-arm-kernel, linux-amlogic, jerry.cao, devicetree, xing.xu, victor.wan On 05/20/2016 10:46 AM, Carlo Caione wrote: > On 20/05/16 10:27, Neil Armstrong wrote: >> Add DT bindings for the Meson GXBB SoC Reset Controller documentation and the >> associated include file. > > [...] > >> +#define RESET_I2C_MASTER_2 142 >> +#define RESET_I2C_MASTER_1 143 >> +/* 144-159 */ >> +/* RESET5 */ >> +/* 160-191 */ >> +/* RESET6 */ >> +#define RESET_PERIPHS_GENERAL 192 >> +#define RESET_PERIPHS_SPICC 193 >> +#define RESET_PERIPHS_SMART_CARD 194 >> +#define RESET_PERIPHS_SAR_ADC 195 >> +#define RESET_PERIPHS_I2C_MASTER_0 196 >> +#define RESET_SANA 197 >> +/* 198 */ >> +#define RESET_PERIPHS_STREAM_INTERFACE 199 >> +#define RESET_PERIPHS_SDIO 200 >> +#define RESET_PERIPHS_UART_0 201 >> +#define RESET_PERIPHS_UART_1_2 202 >> +#define RESET_PERIPHS_ASYNC_0 203 >> +#define RESET_PERIPHS_ASYNC_1 204 >> +#define RESET_PERIPHS_SPI_0 205 >> +#define RESET_PERIPHS_SDHC 206 >> +#define RESET_UART_SLIP 207 >> +/* 208-223 */ >> +/* RESET7 */ >> +#define RESET_USB_DDR_0 224 >> +#define RESET_USB_DDR_1 225 >> +#define RESET_USB_DDR_2 226 >> +#define RESET_USB_DDR_3 227 >> +/* 228 */ >> +#define RESET_DEVICE_MMC_ARB 229 >> +/* 230 */ >> +#define RESET_VID_LOCK 231 >> +#define RESET_A9_DMC_PIPEL 232 >> +/* 233-255 */ >> + >> +#endif > > Indentation looks really messy. Can you just shift the numbers to the > right so that they are on the same column? > Hi Carlo, The patch format makes it very messy, not as in the original format : https://github.com/superna9999/linux/blob/6163f8742454bb7ff962956b4e286d110ec0fb79/include/dt-bindings/reset/amlogic%2Cmeson-gxbb-reset.h Neil ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller 2016-05-20 8:51 ` Neil Armstrong @ 2016-05-20 9:08 ` Carlo Caione 2016-05-20 12:18 ` Neil Armstrong 0 siblings, 1 reply; 13+ messages in thread From: Carlo Caione @ 2016-05-20 9:08 UTC (permalink / raw) To: Neil Armstrong Cc: devicetree, xing.xu, victor.wan, linux-kernel, p.zabel, jerry.cao, linux-amlogic, linux-arm-kernel On 20/05/16 10:51, Neil Armstrong wrote: > On 05/20/2016 10:46 AM, Carlo Caione wrote: > > On 20/05/16 10:27, Neil Armstrong wrote: > >> Add DT bindings for the Meson GXBB SoC Reset Controller documentation and the > >> associated include file. > > > > [...] > > > >> +#define RESET_I2C_MASTER_2 142 > >> +#define RESET_I2C_MASTER_1 143 > >> +/* 144-159 */ > >> +/* RESET5 */ > >> +/* 160-191 */ > >> +/* RESET6 */ > >> +#define RESET_PERIPHS_GENERAL 192 > >> +#define RESET_PERIPHS_SPICC 193 > >> +#define RESET_PERIPHS_SMART_CARD 194 > >> +#define RESET_PERIPHS_SAR_ADC 195 > >> +#define RESET_PERIPHS_I2C_MASTER_0 196 > >> +#define RESET_SANA 197 > >> +/* 198 */ > >> +#define RESET_PERIPHS_STREAM_INTERFACE 199 > >> +#define RESET_PERIPHS_SDIO 200 > >> +#define RESET_PERIPHS_UART_0 201 > >> +#define RESET_PERIPHS_UART_1_2 202 > >> +#define RESET_PERIPHS_ASYNC_0 203 > >> +#define RESET_PERIPHS_ASYNC_1 204 > >> +#define RESET_PERIPHS_SPI_0 205 > >> +#define RESET_PERIPHS_SDHC 206 > >> +#define RESET_UART_SLIP 207 > >> +/* 208-223 */ > >> +/* RESET7 */ > >> +#define RESET_USB_DDR_0 224 > >> +#define RESET_USB_DDR_1 225 > >> +#define RESET_USB_DDR_2 226 > >> +#define RESET_USB_DDR_3 227 > >> +/* 228 */ > >> +#define RESET_DEVICE_MMC_ARB 229 > >> +/* 230 */ > >> +#define RESET_VID_LOCK 231 > >> +#define RESET_A9_DMC_PIPEL 232 > >> +/* 233-255 */ > >> + > >> +#endif > > > > Indentation looks really messy. Can you just shift the numbers to the > > right so that they are on the same column? > > > Hi Carlo, > > The patch format makes it very messy, not as in the original format : > https://github.com/superna9999/linux/blob/6163f8742454bb7ff962956b4e286d110ec0fb79/include/dt-bindings/reset/amlogic%2Cmeson-gxbb-reset.h https://raw.githubusercontent.com/superna9999/linux/6163f8742454bb7ff962956b4e286d110ec0fb79/include/dt-bindings/reset/amlogic%2Cmeson-gxbb-reset.h yes, but 192 -> 200 are not nicely indented to me :) -- Carlo Caione ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller 2016-05-20 9:08 ` Carlo Caione @ 2016-05-20 12:18 ` Neil Armstrong 0 siblings, 0 replies; 13+ messages in thread From: Neil Armstrong @ 2016-05-20 12:18 UTC (permalink / raw) To: Carlo Caione Cc: devicetree, xing.xu, victor.wan, linux-kernel, p.zabel, jerry.cao, linux-amlogic, linux-arm-kernel On 05/20/2016 11:08 AM, Carlo Caione wrote: > On 20/05/16 10:51, Neil Armstrong wrote: >> On 05/20/2016 10:46 AM, Carlo Caione wrote: >>> On 20/05/16 10:27, Neil Armstrong wrote: >>>> Add DT bindings for the Meson GXBB SoC Reset Controller documentation and the >>>> associated include file. >>> >>> [...] >>> >>>> +#define RESET_I2C_MASTER_2 142 >>>> +#define RESET_I2C_MASTER_1 143 >>>> +/* 144-159 */ >>>> +/* RESET5 */ >>>> +/* 160-191 */ >>>> +/* RESET6 */ >>>> +#define RESET_PERIPHS_GENERAL 192 >>>> +#define RESET_PERIPHS_SPICC 193 >>>> +#define RESET_PERIPHS_SMART_CARD 194 >>>> +#define RESET_PERIPHS_SAR_ADC 195 >>>> +#define RESET_PERIPHS_I2C_MASTER_0 196 >>>> +#define RESET_SANA 197 >>>> +/* 198 */ >>>> +#define RESET_PERIPHS_STREAM_INTERFACE 199 >>>> +#define RESET_PERIPHS_SDIO 200 >>>> +#define RESET_PERIPHS_UART_0 201 >>>> +#define RESET_PERIPHS_UART_1_2 202 >>>> +#define RESET_PERIPHS_ASYNC_0 203 >>>> +#define RESET_PERIPHS_ASYNC_1 204 >>>> +#define RESET_PERIPHS_SPI_0 205 >>>> +#define RESET_PERIPHS_SDHC 206 >>>> +#define RESET_UART_SLIP 207 >>>> +/* 208-223 */ >>>> +/* RESET7 */ >>>> +#define RESET_USB_DDR_0 224 >>>> +#define RESET_USB_DDR_1 225 >>>> +#define RESET_USB_DDR_2 226 >>>> +#define RESET_USB_DDR_3 227 >>>> +/* 228 */ >>>> +#define RESET_DEVICE_MMC_ARB 229 >>>> +/* 230 */ >>>> +#define RESET_VID_LOCK 231 >>>> +#define RESET_A9_DMC_PIPEL 232 >>>> +/* 233-255 */ >>>> + >>>> +#endif >>> >>> Indentation looks really messy. Can you just shift the numbers to the >>> right so that they are on the same column? >>> >> Hi Carlo, >> >> The patch format makes it very messy, not as in the original format : >> https://github.com/superna9999/linux/blob/6163f8742454bb7ff962956b4e286d110ec0fb79/include/dt-bindings/reset/amlogic%2Cmeson-gxbb-reset.h > > https://raw.githubusercontent.com/superna9999/linux/6163f8742454bb7ff962956b4e286d110ec0fb79/include/dt-bindings/reset/amlogic%2Cmeson-gxbb-reset.h > > yes, but 192 -> 200 are not nicely indented to me :) > Aw, you got me ! I will add a shift and add a separate meson8b version of this file. Neil ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller 2016-05-20 8:27 ` [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller Neil Armstrong [not found] ` <1463732875-23141-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2016-05-23 21:04 ` Rob Herring 1 sibling, 0 replies; 13+ messages in thread From: Rob Herring @ 2016-05-23 21:04 UTC (permalink / raw) To: Neil Armstrong Cc: linux-kernel, p.zabel, linux-arm-kernel, linux-amlogic, xing.xu, victor.wan, jerry.cao, devicetree On Fri, May 20, 2016 at 10:27:54AM +0200, Neil Armstrong wrote: > Add DT bindings for the Meson GXBB SoC Reset Controller documentation and the > associated include file. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> > --- > .../bindings/reset/amlogic,meson-gxbb-reset.txt | 18 ++ > .../dt-bindings/reset/amlogic,meson-gxbb-reset.h | 199 +++++++++++++++++++++ > 2 files changed, 217 insertions(+) > create mode 100644 Documentation/devicetree/bindings/reset/amlogic,meson-gxbb-reset.txt > create mode 100644 include/dt-bindings/reset/amlogic,meson-gxbb-reset.h Other than the whitespace comments, Acked-by: Rob Herring <robh@kernel.org> ^ permalink raw reply [flat|nested] 13+ messages in thread
* [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms [not found] <1463732875-23141-1-git-send-email-narmstrong@baylibre.com> [not found] ` <1463732875-23141-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2016-05-20 8:27 ` Neil Armstrong [not found] ` <1463732875-23141-4-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 1 sibling, 1 reply; 13+ messages in thread From: Neil Armstrong @ 2016-05-20 8:27 UTC (permalink / raw) To: linux-kernel, p.zabel, linux-arm-kernel, linux-amlogic Cc: Neil Armstrong, xing.xu, victor.wan, jerry.cao, devicetree Update DTSI file to add the reset controller node. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi index 832815d..2463e04 100644 --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi @@ -129,6 +129,12 @@ #size-cells = <2>; ranges = <0x0 0x0 0x0 0xc1100000 0x0 0x100000>; + reset: reset-controller@4404 { + compatible = "amlogic,meson-gxbb-reset"; + reg = <0x0 0x04404 0x0 0x20>; + #reset-cells = <1>; + }; + uart_A: serial@84c0 { compatible = "amlogic,meson-uart"; reg = <0x0 0x084c0 0x0 0x14>; -- 2.7.0 ^ permalink raw reply related [flat|nested] 13+ messages in thread
[parent not found: <1463732875-23141-4-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms [not found] ` <1463732875-23141-4-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2016-05-20 8:47 ` Carlo Caione 2016-05-20 8:53 ` Neil Armstrong 0 siblings, 1 reply; 13+ messages in thread From: Carlo Caione @ 2016-05-20 8:47 UTC (permalink / raw) To: Neil Armstrong Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, jerry.cao-LpR1jeaWuhtBDgjK7y7TUQ, devicetree-u79uwXL29TY76Z2rM5mHXA, xing.xu-LpR1jeaWuhtBDgjK7y7TUQ, victor.wan-LpR1jeaWuhtBDgjK7y7TUQ On 20/05/16 10:27, Neil Armstrong wrote: > Update DTSI file to add the reset controller node. > > Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> > --- > arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > index 832815d..2463e04 100644 > --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > @@ -129,6 +129,12 @@ > #size-cells = <2>; > ranges = <0x0 0x0 0x0 0xc1100000 0x0 0x100000>; > > + reset: reset-controller@4404 { > + compatible = "amlogic,meson-gxbb-reset"; > + reg = <0x0 0x04404 0x0 0x20>; > + #reset-cells = <1>; > + }; > + > uart_A: serial@84c0 { > compatible = "amlogic,meson-uart"; > reg = <0x0 0x084c0 0x0 0x14>; Missing #include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> ? Thanks, -- Carlo Caione -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms 2016-05-20 8:47 ` Carlo Caione @ 2016-05-20 8:53 ` Neil Armstrong [not found] ` <573ED06F.9070909-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> 0 siblings, 1 reply; 13+ messages in thread From: Neil Armstrong @ 2016-05-20 8:53 UTC (permalink / raw) To: Carlo Caione Cc: linux-kernel, p.zabel, linux-arm-kernel, linux-amlogic, jerry.cao, devicetree, xing.xu, victor.wan On 05/20/2016 10:47 AM, Carlo Caione wrote: > On 20/05/16 10:27, Neil Armstrong wrote: >> Update DTSI file to add the reset controller node. >> >> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >> --- >> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >> index 832815d..2463e04 100644 >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >> @@ -129,6 +129,12 @@ >> #size-cells = <2>; >> ranges = <0x0 0x0 0x0 0xc1100000 0x0 0x100000>; >> >> + reset: reset-controller@4404 { >> + compatible = "amlogic,meson-gxbb-reset"; >> + reg = <0x0 0x04404 0x0 0x20>; >> + #reset-cells = <1>; >> + }; >> + >> uart_A: serial@84c0 { >> compatible = "amlogic,meson-uart"; >> reg = <0x0 0x084c0 0x0 0x14>; > > Missing #include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> ? > > Thanks, > Shouldn't we wait until the reset bindings are actually used in the dtsi ? I'm quite sure kevin will post it with the Ethernet nodes. Neil ^ permalink raw reply [flat|nested] 13+ messages in thread
[parent not found: <573ED06F.9070909-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>]
* Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms [not found] ` <573ED06F.9070909-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> @ 2016-05-20 9:10 ` Carlo Caione 2016-05-20 12:19 ` Neil Armstrong 0 siblings, 1 reply; 13+ messages in thread From: Carlo Caione @ 2016-05-20 9:10 UTC (permalink / raw) To: Neil Armstrong Cc: devicetree-u79uwXL29TY76Z2rM5mHXA, xing.xu-LpR1jeaWuhtBDgjK7y7TUQ, victor.wan-LpR1jeaWuhtBDgjK7y7TUQ, linux-kernel-u79uwXL29TY76Z2rM5mHXA, p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ, jerry.cao-LpR1jeaWuhtBDgjK7y7TUQ, linux-amlogic-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r On 20/05/16 10:53, Neil Armstrong wrote: > On 05/20/2016 10:47 AM, Carlo Caione wrote: > > On 20/05/16 10:27, Neil Armstrong wrote: > >> Update DTSI file to add the reset controller node. > >> > >> Signed-off-by: Neil Armstrong <narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org> > >> --- > >> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > >> index 832815d..2463e04 100644 > >> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > >> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi > >> @@ -129,6 +129,12 @@ > >> #size-cells = <2>; > >> ranges = <0x0 0x0 0x0 0xc1100000 0x0 0x100000>; > >> > >> + reset: reset-controller@4404 { > >> + compatible = "amlogic,meson-gxbb-reset"; > >> + reg = <0x0 0x04404 0x0 0x20>; > >> + #reset-cells = <1>; > >> + }; > >> + > >> uart_A: serial@84c0 { > >> compatible = "amlogic,meson-uart"; > >> reg = <0x0 0x084c0 0x0 0x14>; > > > > Missing #include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> ? > > > > Thanks, > > > > Shouldn't we wait until the reset bindings are actually used in the dtsi ? > I'm quite sure kevin will post it with the Ethernet nodes. Why? The header file is related to the reset controller. Better add it now with this patchset. Cheers, -- Carlo Caione -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms 2016-05-20 9:10 ` Carlo Caione @ 2016-05-20 12:19 ` Neil Armstrong 2016-05-20 12:22 ` Carlo Caione 0 siblings, 1 reply; 13+ messages in thread From: Neil Armstrong @ 2016-05-20 12:19 UTC (permalink / raw) To: Carlo Caione Cc: devicetree, xing.xu, victor.wan, linux-kernel, p.zabel, jerry.cao, linux-amlogic, linux-arm-kernel On 05/20/2016 11:10 AM, Carlo Caione wrote: > On 20/05/16 10:53, Neil Armstrong wrote: >> On 05/20/2016 10:47 AM, Carlo Caione wrote: >>> On 20/05/16 10:27, Neil Armstrong wrote: >>>> Update DTSI file to add the reset controller node. >>>> >>>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> >>>> --- >>>> arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >>>> index 832815d..2463e04 100644 >>>> --- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >>>> +++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi >>>> @@ -129,6 +129,12 @@ >>>> #size-cells = <2>; >>>> ranges = <0x0 0x0 0x0 0xc1100000 0x0 0x100000>; >>>> >>>> + reset: reset-controller@4404 { >>>> + compatible = "amlogic,meson-gxbb-reset"; >>>> + reg = <0x0 0x04404 0x0 0x20>; >>>> + #reset-cells = <1>; >>>> + }; >>>> + >>>> uart_A: serial@84c0 { >>>> compatible = "amlogic,meson-uart"; >>>> reg = <0x0 0x084c0 0x0 0x14>; >>> >>> Missing #include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> ? >>> >>> Thanks, >>> >> >> Shouldn't we wait until the reset bindings are actually used in the dtsi ? >> I'm quite sure kevin will post it with the Ethernet nodes. > > Why? The header file is related to the reset controller. Better add it > now with this patchset. > > Cheers, > OK, I will add it in gxbb and meson8b dtsi files. Neil ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms 2016-05-20 12:19 ` Neil Armstrong @ 2016-05-20 12:22 ` Carlo Caione 2016-05-20 12:23 ` Neil Armstrong 0 siblings, 1 reply; 13+ messages in thread From: Carlo Caione @ 2016-05-20 12:22 UTC (permalink / raw) To: Neil Armstrong Cc: devicetree, xing.xu, victor.wan, linux-kernel, p.zabel, linux-amlogic, jerry.cao, linux-arm-kernel On 20/05/16 14:19, Neil Armstrong wrote: [...] > >>> Missing #include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> ? > >>> > >>> Thanks, > >>> > >> > >> Shouldn't we wait until the reset bindings are actually used in the dtsi ? > >> I'm quite sure kevin will post it with the Ethernet nodes. > > > > Why? The header file is related to the reset controller. Better add it > > now with this patchset. > > > > Cheers, > > > > OK, I will add it in gxbb and meson8b dtsi files. Why also meson8b DTSI? -- Carlo Caione ^ permalink raw reply [flat|nested] 13+ messages in thread
* Re: [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms 2016-05-20 12:22 ` Carlo Caione @ 2016-05-20 12:23 ` Neil Armstrong 0 siblings, 0 replies; 13+ messages in thread From: Neil Armstrong @ 2016-05-20 12:23 UTC (permalink / raw) To: Carlo Caione Cc: devicetree, xing.xu, victor.wan, linux-kernel, p.zabel, linux-amlogic, jerry.cao, linux-arm-kernel On 05/20/2016 02:22 PM, Carlo Caione wrote: > On 20/05/16 14:19, Neil Armstrong wrote: > > [...] >>>>> Missing #include <dt-bindings/reset/amlogic,meson-gxbb-reset.h> ? >>>>> >>>>> Thanks, >>>>> >>>> >>>> Shouldn't we wait until the reset bindings are actually used in the dtsi ? >>>> I'm quite sure kevin will post it with the Ethernet nodes. >>> >>> Why? The header file is related to the reset controller. Better add it >>> now with this patchset. >>> >>> Cheers, >>> >> >> OK, I will add it in gxbb and meson8b dtsi files. > > Why also meson8b DTSI? > Sorry, I'll add the meson8b specific header of course. Neil ^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2016-05-23 21:04 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1463732875-23141-1-git-send-email-narmstrong@baylibre.com>
[not found] ` <1463732875-23141-1-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-05-20 8:27 ` [PATCH 2/3] dt-bindings: reset: Add bindings for the Meson GXBB Reset Controller Neil Armstrong
[not found] ` <1463732875-23141-3-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-05-20 8:46 ` Carlo Caione
2016-05-20 8:51 ` Neil Armstrong
2016-05-20 9:08 ` Carlo Caione
2016-05-20 12:18 ` Neil Armstrong
2016-05-23 21:04 ` Rob Herring
2016-05-20 8:27 ` [PATCH 3/3] ARM64: dts: amlogic: Enable Reset Controller on GXBB-based platforms Neil Armstrong
[not found] ` <1463732875-23141-4-git-send-email-narmstrong-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-05-20 8:47 ` Carlo Caione
2016-05-20 8:53 ` Neil Armstrong
[not found] ` <573ED06F.9070909-rdvid1DuHRBWk0Htik3J/w@public.gmane.org>
2016-05-20 9:10 ` Carlo Caione
2016-05-20 12:19 ` Neil Armstrong
2016-05-20 12:22 ` Carlo Caione
2016-05-20 12:23 ` Neil Armstrong
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).