From: Nicolin Chen <nicoleotsuka@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: broonie@kernel.org, brian.austin@cirrus.com,
Paul.Handrigan@cirrus.com, pawel.moll@arm.com,
mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
galak@codeaurora.org, lgirdwood@gmail.com, Tim.Howe@cirrus.com,
somduttar@nvidia.com, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v6] ASoC: cs53l30: Add codec driver support for Cirrus CS53L30
Date: Wed, 25 May 2016 10:37:24 -0700 [thread overview]
Message-ID: <20160525173724.GA20293@Asurada-Nvidia> (raw)
In-Reply-To: <20160525172800.GB3056@rob-hp-laptop>
On Wed, May 25, 2016 at 12:28:00PM -0500, Rob Herring wrote:
> > diff --git a/Documentation/devicetree/bindings/sound/cs53l30.txt b/Documentation/devicetree/bindings/sound/cs53l30.txt
> > new file mode 100644
> > index 0000000..ace7ffe
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/sound/cs53l30.txt
> > @@ -0,0 +1,38 @@
> > +CS53L30 audio CODEC
> > +
> > +Required properties:
> > +
> > + - compatible : "cirrus,cs53l30"
> > +
> > + - reg : the I2C address of the device
> > +
> > + - VA-supply, VP-supply : power supplies for the device,
> > + as covered in Documentation/devicetree/bindings/regulator/regulator.txt.
> Also, these are missing from the example yet are required. I'd argue
> they should be optional as you could have designs with no regulator
> control.
Will refine both in next ver. Thanks
next prev parent reply other threads:[~2016-05-25 17:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 23:13 [PATCH v6] ASoC: cs53l30: Add codec driver support for Cirrus CS53L30 Nicolin Chen
2016-05-25 17:26 ` Rob Herring
2016-05-25 17:28 ` Rob Herring
2016-05-25 17:37 ` Nicolin Chen [this message]
2016-05-25 18:16 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160525173724.GA20293@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=Tim.Howe@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh@kernel.org \
--cc=somduttar@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).