From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: Re: [PATCH 1/2] Revert "mtd: atmel_nand: Support variable RB_EDGE interrupts" Date: Thu, 26 May 2016 08:36:15 +0200 Message-ID: <20160526083615.6960686d@bbrezillon> References: <1462776680-5284-1-git-send-email-wenyou.yang@atmel.com> <1462776680-5284-2-git-send-email-wenyou.yang@atmel.com> <20160526031654.GA107505@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20160526031654.GA107505@google.com> Sender: linux-kernel-owner@vger.kernel.org To: Brian Norris , linux-kernel@vger.kernel.org Cc: Wenyou Yang , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , Jean-Christophe Plagniol-Villard , Nicolas Ferre , Rob Herring , Mark Brown , linux-mtd@lists.infradead.org, Kumar Gala , Alexandre Belloni , David Woodhouse , Josh Wu , linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org On Wed, 25 May 2016 20:16:54 -0700 Brian Norris wrote: > Hi, > > On Mon, May 09, 2016 at 02:51:18PM +0800, Wenyou Yang wrote: > > This reverts commit 5ddc7bd43ccc ("mtd: atmel_nand: Support variable > > RB_EDGE interrupts") > > > > Because for current SoCs, the RB_EDGE3(i.e. bit 27) of HSMC_SR > > register does not exist, the RB_EDGE0 (i.e. bit 24) is the ready/busy > > line edge status bit. It is a datasheet bug. > > > > Signed-off-by: Wenyou Yang > > --- > > > > .../devicetree/bindings/mtd/atmel-nand.txt | 2 +- > > drivers/mtd/nand/atmel_nand.c | 35 +++++----------------- > > drivers/mtd/nand/atmel_nand_nfc.h | 3 +- > > 3 files changed, 10 insertions(+), 30 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/mtd/atmel-nand.txt b/Documentation/devicetree/bindings/mtd/atmel-nand.txt > > index d53aba9..3e7ee99 100644 > > --- a/Documentation/devicetree/bindings/mtd/atmel-nand.txt > > +++ b/Documentation/devicetree/bindings/mtd/atmel-nand.txt > > @@ -39,7 +39,7 @@ Optional properties: > > > > Nand Flash Controller(NFC) is an optional sub-node > > Required properties: > > -- compatible : "atmel,sama5d3-nfc" or "atmel,sama5d4-nfc". > > +- compatible : "atmel,sama5d3-nfc". > > - reg : should specify the address and size used for NFC command registers, > > NFC registers and NFC SRAM. NFC SRAM address and size can be absent > > if don't want to use it. > > diff --git a/drivers/mtd/nand/atmel_nand.c b/drivers/mtd/nand/atmel_nand.c > > index efc8ea2..68b9160 100644 > > --- a/drivers/mtd/nand/atmel_nand.c > > +++ b/drivers/mtd/nand/atmel_nand.c > [...] > > static const struct of_device_id atmel_nand_nfc_match[] = { > > - { .compatible = "atmel,sama5d3-nfc", .data = &sama5d3_nfc_caps }, > > - { .compatible = "atmel,sama5d4-nfc", .data = &sama5d4_nfc_caps }, > > + { .compatible = "atmel,sama5d3-nfc" }, > > Hmm, wait. Didn't Rob and Alexandre suggest that we should *not* drop > the compatible property? We could have easily supported both here, and > just not listed any different capabilities. But I see that Nicholas took > the patch anyway, so I guess it's not a big deal... Yes, actually the compatible change was introduced and fixed in the same release, so I don't think the stable ABI argument stands here. -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com