From: Guenter Roeck <linux@roeck-us.net>
To: Hoan Tran <hotran@apm.com>
Cc: Jean Delvare <jdelvare@suse.com>,
Jonathan Corbet <corbet@lwn.net>,
Rob Herring <robh+dt@kernel.org>,
Jassi Brar <jassisinghbrar@gmail.com>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
Duc Dang <dhdang@apm.com>, Loc Ho <lho@apm.com>,
linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org
Subject: Re: [2/3] hwmon: xgene: Adds hwmon driver
Date: Wed, 1 Jun 2016 11:10:49 -0700 [thread overview]
Message-ID: <20160601181049.GA10954@roeck-us.net> (raw)
In-Reply-To: <CAFHUOYzWj_PbbpzCW5CjO7d3uc7x2h8UvHrYmDoKyttNQVDDZA@mail.gmail.com>
On Tue, May 31, 2016 at 11:00:05PM -0700, Hoan Tran wrote:
> Hi Guenter,
>
> >
> > Overall, I have to say that the code is quite complex due to the repeated
> > checks for ACPI. I am close to suggest having two separate drivers,
> > one for ACPI and one for non-ACPI. Any chance to separate ACPI vs. non-ACPI
> > code a bit better ?
>
> How about create separate rx_cb functions for ACPI and non-ACPI ?
Yes, that would be great if it is possible.
> As almost functions are the same between ACPI and non-ACPI, I thought
> keep the same driver is still OK, isn't it ?
>
If you can separate the ACPI code from the non-ACPI code a bit better than
right now, yes.
Thanks,
Guenter
next prev parent reply other threads:[~2016-06-01 18:10 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-16 16:17 [PATCH 0/3] Add support for X-Gene hwmon driver Hoan Tran
2016-05-16 16:17 ` [PATCH 1/3] Documentation: dtb: xgene: Add hwmon dts binding documentation Hoan Tran
2016-05-23 20:30 ` Rob Herring
2016-05-24 1:01 ` Hoan Tran
2016-05-25 17:09 ` Rob Herring
2016-06-07 16:31 ` Hoan Tran
2016-06-07 17:20 ` Jassi Brar
2016-06-07 18:05 ` Hoan Tran
2016-06-23 16:42 ` Hoan Tran
2016-05-16 16:17 ` [PATCH 2/3] hwmon: xgene: Adds hwmon driver Hoan Tran
2016-05-30 5:25 ` [2/3] " Guenter Roeck
2016-06-01 6:00 ` Hoan Tran
2016-06-01 18:10 ` Guenter Roeck [this message]
2016-05-16 16:17 ` [PATCH 3/3] arm64: dts: apm: Add X-Gene SoC hwmon to device tree Hoan Tran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160601181049.GA10954@roeck-us.net \
--to=linux@roeck-us.net \
--cc=ashwin.chaugule@linaro.org \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=dhdang@apm.com \
--cc=hotran@apm.com \
--cc=jassisinghbrar@gmail.com \
--cc=jdelvare@suse.com \
--cc=lho@apm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).