From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Ricard Wanderlof <ricard.wanderlof@axis.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
Benoit Cousson <bcousson@baylibre.com>,
Tony Lindgren <tony@atomide.com>,
devicetree@vger.kernel.org,
Linux mtd <linux-mtd@lists.infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/4] mtd: nand: Add support for Evatronix NANDFLASH-CTRL
Date: Thu, 2 Jun 2016 18:00:59 +0200 [thread overview]
Message-ID: <20160602180059.11928d40@bbrezillon> (raw)
In-Reply-To: <alpine.DEB.2.02.1606020944180.19416@lnxricardw1.se.axis.com>
Hi Ricard,
I was not in Cc of this series, so you're either developing an old
kernel version, or you didn't check the MAINTAINERS file (or didn't run
get_maintainer.pl on your series). And please, next time make sure
patches 1 to X are sent in replies to your cover letter.
On Thu, 2 Jun 2016 09:46:31 +0200
Ricard Wanderlof <ricard.wanderlof@axis.com> wrote:
> This patch set adds a driver and relevant devicetree bindings for the
> Evatronix NANDFLASH-CTRL NAND flash controller IP. This controller is
> used in the Axis ARTPEC-6 SoC.
>
> The driver supports BCH ECC using the controller's hardware, but there is
> also an option to use software BCH ECC. However, the ECC layouts are not
> compatible so it's not possible to mix them. The main advantage to using
> software ECC is that there are more OOB bytes free, as the hardware is
> slightly wasteful on OOB space.
>
> BCH ECC from 4 to 32 bits over 256, 512 or 1024 byte ECC blocks is supported.
>
> Only large-page flash chips are supported, using 4 or 5 address cycles.
>
> The driver has been extensively tested using hardware ECC on 2 Mbit flash chips,
> with 8 bit ECC over 512 bytes ECC blocks.
I'll to review the driver soon.
Regards,
Boris
>
> Ricard Wanderlof (4):
> of: Add device tree bindings for Evatronix NANDFLASH-CTRL
> dts: Add Evatronix NAND flash driver to ARTPEC-6 dtsi
> mtd: nand: Add support for Evatronix NANDFLASH-CTRL
> MAINTAINERS: mtd: Add maintainer for Evatronix NAND flash driver
>
> .../devicetree/bindings/mtd/evatronix-nand.txt | 44 +
> .../devicetree/bindings/vendor-prefixes.txt | 1 +
> MAINTAINERS | 6 +
> arch/arm/boot/dts/artpec6.dtsi | 19 +
> drivers/mtd/nand/Kconfig | 6 +
> drivers/mtd/nand/Makefile | 1 +
> drivers/mtd/nand/evatronix_nand.c | 1909 ++++++++++++++++++++
> 7 files changed, 1986 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mtd/evatronix-nand.txt
> create mode 100644 drivers/mtd/nand/evatronix_nand.c
>
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
next prev parent reply other threads:[~2016-06-02 16:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 7:46 [PATCH 0/4] mtd: nand: Add support for Evatronix NANDFLASH-CTRL Ricard Wanderlof
2016-06-02 16:00 ` Boris Brezillon [this message]
2016-06-06 5:47 ` Ricard Wanderlof
2016-06-06 11:02 ` Kamlakant Patel
2016-06-07 9:02 ` Ricard Wanderlof
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160602180059.11928d40@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=bcousson@baylibre.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ricard.wanderlof@axis.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).