[PATCH 0/4] mtd: nand: Add support for Evatronix NANDFLASH-CTRL

[PATCH 0/4] mtd: nand: Add support for Evatronix NANDFLASH-CTRL

[Ricard Wanderlof]

This patch set adds a driver and relevant devicetree bindings for the
Evatronix NANDFLASH-CTRL NAND flash controller IP. This controller is
used in the Axis ARTPEC-6 SoC.

The driver supports BCH ECC using the controller's hardware, but there is
also an option to use software BCH ECC. However, the ECC layouts are not
compatible so it's not possible to mix them. The main advantage to using
software ECC is that there are more OOB bytes free, as the hardware is
slightly wasteful on OOB space.

BCH ECC from 4 to 32 bits over 256, 512 or 1024 byte ECC blocks is supported.

Only large-page flash chips are supported, using 4 or 5 address cycles.

The driver has been extensively tested using hardware ECC on 2 Mbit flash chips,
with 8 bit ECC over 512 bytes ECC blocks.

Ricard Wanderlof (4):
  of: Add device tree bindings for Evatronix NANDFLASH-CTRL
  dts: Add Evatronix NAND flash driver to ARTPEC-6 dtsi
  mtd: nand: Add support for Evatronix NANDFLASH-CTRL
  MAINTAINERS: mtd: Add maintainer for Evatronix NAND flash driver

 .../devicetree/bindings/mtd/evatronix-nand.txt     |   44 +
 .../devicetree/bindings/vendor-prefixes.txt        |    1 +
 MAINTAINERS                                        |    6 +
 arch/arm/boot/dts/artpec6.dtsi                     |   19 +
 drivers/mtd/nand/Kconfig                           |    6 +
 drivers/mtd/nand/Makefile                          |    1 +
 drivers/mtd/nand/evatronix_nand.c                  | 1909 ++++++++++++++++++++
 7 files changed, 1986 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mtd/evatronix-nand.txt
 create mode 100644 drivers/mtd/nand/evatronix_nand.c

-- 
1.7.10.4


-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30

Re: [PATCH 0/4] mtd: nand: Add support for Evatronix NANDFLASH-CTRL

[Boris Brezillon]

Hi Ricard,

I was not in Cc of this series, so you're either developing an old
kernel version, or you didn't check the MAINTAINERS file (or didn't run
get_maintainer.pl on your series). And please, next time make sure
patches 1 to X are sent in replies to your cover letter.

On Thu, 2 Jun 2016 09:46:31 +0200
Ricard Wanderlof <ricard.wanderlof@axis.com> wrote:

> This patch set adds a driver and relevant devicetree bindings for the
> Evatronix NANDFLASH-CTRL NAND flash controller IP. This controller is
> used in the Axis ARTPEC-6 SoC.
> 
> The driver supports BCH ECC using the controller's hardware, but there is
> also an option to use software BCH ECC. However, the ECC layouts are not
> compatible so it's not possible to mix them. The main advantage to using
> software ECC is that there are more OOB bytes free, as the hardware is
> slightly wasteful on OOB space.
> 
> BCH ECC from 4 to 32 bits over 256, 512 or 1024 byte ECC blocks is supported.
> 
> Only large-page flash chips are supported, using 4 or 5 address cycles.
> 
> The driver has been extensively tested using hardware ECC on 2 Mbit flash chips,
> with 8 bit ECC over 512 bytes ECC blocks.

I'll to review the driver soon.

Regards,

Boris

> 
> Ricard Wanderlof (4):
>   of: Add device tree bindings for Evatronix NANDFLASH-CTRL
>   dts: Add Evatronix NAND flash driver to ARTPEC-6 dtsi
>   mtd: nand: Add support for Evatronix NANDFLASH-CTRL
>   MAINTAINERS: mtd: Add maintainer for Evatronix NAND flash driver
> 
>  .../devicetree/bindings/mtd/evatronix-nand.txt     |   44 +
>  .../devicetree/bindings/vendor-prefixes.txt        |    1 +
>  MAINTAINERS                                        |    6 +
>  arch/arm/boot/dts/artpec6.dtsi                     |   19 +
>  drivers/mtd/nand/Kconfig                           |    6 +
>  drivers/mtd/nand/Makefile                          |    1 +
>  drivers/mtd/nand/evatronix_nand.c                  | 1909 ++++++++++++++++++++
>  7 files changed, 1986 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mtd/evatronix-nand.txt
>  create mode 100644 drivers/mtd/nand/evatronix_nand.c
> 



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

Re: [PATCH 0/4] mtd: nand: Add support for Evatronix NANDFLASH-CTRL

[Ricard Wanderlof]

On Thu, 2 Jun 2016, Boris Brezillon wrote:

> Hi Ricard,
> 
> I was not in Cc of this series, so you're either developing an old
> kernel version, or you didn't check the MAINTAINERS file (or didn't run
> get_maintainer.pl on your series).

The patch is intended to apply to the mtd l2 tree, and I did check 
MAINTAINERS, however, for whatever reason I failed to notice that the NAND 
flash subsystem has its own entry (going for the general MTD entry), so 
both you and Richard got left off the CC list. Sorry about that. I'll 
rectify it on subsequent patch submissions.

> And please, next time make sure patches 1 to X are sent in replies to 
> your cover letter.

Ok. Will do.

> I'll to review the driver soon.

Much appreciated.

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30

Re: [PATCH 0/4] mtd: nand: Add support for Evatronix NANDFLASH-CTRL

[Kamlakant Patel]

On Mon, Jun 6, 2016 at 11:17 AM, Ricard Wanderlof
<ricard.wanderlof@axis.com> wrote:
>
> On Thu, 2 Jun 2016, Boris Brezillon wrote:
>
>> Hi Ricard,
>>
>> I was not in Cc of this series, so you're either developing an old
>> kernel version, or you didn't check the MAINTAINERS file (or didn't run
>> get_maintainer.pl on your series).
>
> The patch is intended to apply to the mtd l2 tree, and I did check
> MAINTAINERS, however, for whatever reason I failed to notice that the NAND
> flash subsystem has its own entry (going for the general MTD entry), so
> both you and Richard got left off the CC list. Sorry about that. I'll
> rectify it on subsequent patch submissions.
>
>> And please, next time make sure patches 1 to X are sent in replies to
>> your cover letter.
>
> Ok. Will do.
>
>> I'll to review the driver soon.
>
> Much appreciated.

Hi Ricard,

I am using the previous version of your patch on Netlogic XLP MIPS64
platform with some cleanups, some of them are mentioned by Borris.
I can send you the patch if you would like to integrate it.

Thanks,
 Kamlakant Patel

Re: [PATCH 0/4] mtd: nand: Add support for Evatronix NANDFLASH-CTRL

[Ricard Wanderlof]

On Mon, 6 Jun 2016, Kamlakant Patel wrote:

> Hi Ricard,
> 
> I am using the previous version of your patch on Netlogic XLP MIPS64 
> platform with some cleanups, some of them are mentioned by Borris. I can 
> send you the patch if you would like to integrate it.

Sure, that would be great!

/Ricard
-- 
Ricard Wolf Wanderlöf                           ricardw(at)axis.com
Axis Communications AB, Lund, Sweden            www.axis.com
Phone +46 46 272 2016                           Fax +46 46 13 61 30