Re: [PATCH 07/13] ARM: dts: r8a7792: initial SoC device tree

Simon Horman
2016-06-10T01:02:45Z

On Tue, Jun 07, 2016 at 11:58:45PM +0300, Sergei Shtylyov wrote:
> On 06/07/2016 10:13 AM, Geert Uytterhoeven wrote:
>
> [...]
>
> >>>And that the system behaves sanely on suspend/resume.
> >>
> >> I'd be thankful if you told me how to test that. :-)
> >
> >System suspend:
> >
> > echo mem > /sys/power/state
>
> Oh. I know that one! :-)
>
> >System resume: You're gonna need a "wakeup-source" in your DTS, e.g. gpio-keys.
> >Serial should work too, echo "enabled" to the corresponding wakeup
> >file in /sys first.
>
> I'm afraid I couldn't find that file. All I saw were RPM controls...
>
> >In case of issues, try "echo 0 > /sys/module/printk/parameters/console_suspend".
>
> There's no problems suspending, it's the resuming that's a problem for me.
>
> >Good luck!
>
> As usual, there was no luck. :-)
>
> WBR, Sergei

Does resume work for UP (i.e. without SMP)?

How did testing CPU hotplug go? Did it work for all CPUs?

If things work less well for SMP than UP I am inclined to ask
you to defer adding SMP support.