Re: [PATCH 13/13] ARM: dts: blanche: add Ethernet support

Sergei Shtylyov
2016-06-02T21:33:05Z

On 06/01/2016 03:27 PM, Geert Uytterhoeven wrote:

>>>> --- renesas.orig/arch/arm/boot/dts/r8a7792-blanche.dts
>>>> +++ renesas/arch/arm/boot/dts/r8a7792-blanche.dts
>>>
>>>> + ethernet@18000000 {
>>>> + compatible = "smsc,lan89218", "smsc,lan9115";
>>>
>>>
>>> The "smsc,lan89218" needs to be documented in the device tree bindings.
>>
>> Have you looked at those bindings?
>
> Now I did.
>
>>> Google couldn't find any evidence you submitted a patch for that.
>>
>> Because the bindings document *any* LAN9115 compatible chip already.
>
> Ah, generic wildcard, not listing valid values. Hence checkpatch complained...

Note that it doesn't complain about "smsc,lan9220" though that is only
mentioned in the example.

> Google predict-while-you-type suggests "lan89218aq"? Should you use that?

No, my googling shows that the suffix can be different, and the Microchip
(the new owner?) has it without the suffix on their site.

> BTW, that's why we always want to document all valid values...

> Gr{oetje,eeting}s,
>
> Geert

MBR, Sergei