Re: [PATCH 10/13] ARM: dts: r8a7792: add IRQC support

Sergei Shtylyov
2016-06-01T14:02:39Z

On 06/01/2016 04:18 AM, Simon Horman wrote:

>> Describe the IRQC interrupt controller in the R8A7792 device tree.
>>
>> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
>>
>> ---
>> arch/arm/boot/dts/r8a7792.dtsi | 13 +++++++++++++
>> 1 file changed, 13 insertions(+)
>>
>> Index: renesas/arch/arm/boot/dts/r8a7792.dtsi
>> ===================================================================
>> --- renesas.orig/arch/arm/boot/dts/r8a7792.dtsi
>> +++ renesas/arch/arm/boot/dts/r8a7792.dtsi
>> @@ -62,6 +62,19 @@
>> IRQ_TYPE_LEVEL_HIGH)>;
>> };
>>
>> + irqc: interrupt-controller@e61c0000 {
>
> Could you consider using irqc0 as the node name for consistency with the
> DT of other R-Car Gen2 SoCs?

Frankly speaking I didn't get that name indexing thing at all. Could you
share the reasoning behind it?

> What follows looks correct to me.

Thank you. :-)

MBR, Sergei