From mboxrd@z Thu Jan 1 00:00:00 1970 From: Will Deacon Subject: Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block Date: Fri, 3 Jun 2016 10:45:20 +0100 Message-ID: <20160603094520.GF9915@arm.com> References: <1464427377-12712-1-git-send-email-thunder.leizhen@huawei.com> <1464427377-12712-3-git-send-email-thunder.leizhen@huawei.com> <574F8DA8.4040503@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <574F8DA8.4040503-hv44wF8Li93QT0dZR+AlfA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Leizhen (ThunderTown)" Cc: Rob Herring , devicetree , David Daney , Catalin Marinas , Xinwei Hu , Hanjun Guo , linux-kernel , Robert Richter , Zefan Li , Tianhong Ding , Grant Likely , Ganapatrao Kulkarni , Frank Rowand , linux-arm-kernel List-Id: devicetree@vger.kernel.org On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote: > On 2016/6/2 4:13, Rob Herring wrote: > > I believe you still need this and not the one above. You only need it > > within the loop if you return. Otherwise, the last node always need to > > be put. > > OK. Thanks. > > Addition with Matthias's suggestion, I will move "return" into this patch, > so that this of_node_put(np) can be safely removed. Do you want to include Kefeng's [1] patches in your series too? We don't need two sets of related NUMA cleanups :) Will [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2016-June/432715.html -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html