From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v5 1/2] drm/bridge: Add sii902x driver Date: Fri, 3 Jun 2016 13:15:10 +0200 Message-ID: <20160603111510.GA4594@piout.net> References: <1464879601-30569-1-git-send-email-boris.brezillon@free-electrons.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Emil Velikov Cc: Boris Brezillon , David Airlie , Daniel Vetter , ML dri-devel , Mark Rutland , Meng Yi , Xiubo Li , Pawel Moll , Ian Campbell , Alison Wang , Nicolas Ferre , devicetree , Rob Herring , Kumar Gala , Jean-Christophe Plagniol-Villard , Jianwei Wang List-Id: devicetree@vger.kernel.org Hi, On 03/06/2016 at 10:38:49 +0100, Emil Velikov wrote : > On 2 June 2016 at 16:00, Boris Brezillon > wrote: > > + > > + if (client->irq > 0) { > I was always confused which is the correct way to check this >= 0 vs > > 0. DRM has both :-\ > Do you have any suggestions, should be 'mass convert' DRM to use only > one of the two ? > 0 is an invalid irq number for any i2c devices since dab472eb931bc2916fa779e56deccd0ec319cf5b. -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html