From: Rob Herring <robh@kernel.org>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: grant.likely@linaro.org, devicetree@vger.kernel.org,
frowand.list@gmail.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of: irq: fix of_irq_get[_byname]() kernel-doc
Date: Fri, 3 Jun 2016 07:08:10 -0500 [thread overview]
Message-ID: <20160603120810.GA8472@rob-hp-laptop> (raw)
In-Reply-To: <4469041.XrtPizO4V9@wasted.cogentembedded.com>
On Sat, May 28, 2016 at 11:02:50PM +0300, Sergei Shtylyov wrote:
> The kernel-doc for the of_irq_get[_byname]() is clearly inadequate in
> describing the return values -- of_irq_get_byname() is documented better
> than of_irq_get() but it still doesn't mention that 0 is returned iff
> irq_create_of_mapping() fails (it doesn't return an error code in this
> case). Document all possible return value variants, making the writing
> of the word "IRQ" consistent, while at it...
>
> Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
> Fixes: ad69674e73a1 ("of/irq: do irq resolution in platform_get_irq_byname()")
> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> CC: stable@vger.kernel.org
>
> ---
> The patch is against Linus' 'linux.git' repo (Grant Likely's repo is outdated).
>
> drivers/of/irq.c | 19 ++++++++++---------
> 1 file changed, 10 insertions(+), 9 deletions(-)
Applied, thanks.
Rob
prev parent reply other threads:[~2016-06-03 12:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-28 20:02 [PATCH] of: irq: fix of_irq_get[_byname]() kernel-doc Sergei Shtylyov
2016-06-03 12:08 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160603120810.GA8472@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=grant.likely@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox