From: Vinod Koul <vinod.koul@intel.com>
To: Peter Griffin <peter.griffin@linaro.org>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com,
maxime.coquelin@st.com, patrice.chotard@st.com, ohad@wizery.com,
bjorn.andersson@linaro.org, arnd@arndb.de, lee.jones@linaro.org,
devicetree@vger.kernel.org, dmaengine@vger.kernel.org,
linux-remoteproc@vger.kernel.org,
Ludovic Barre <ludovic.barre@st.com>
Subject: Re: [PATCH v4 05/18] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file
Date: Mon, 6 Jun 2016 10:06:19 +0530 [thread overview]
Message-ID: <20160606043618.GV16910@localhost> (raw)
In-Reply-To: <1464192412-16386-7-git-send-email-peter.griffin@linaro.org>
On Wed, May 25, 2016 at 05:06:39PM +0100, Peter Griffin wrote:
> +/*
> + * request control bits
> + */
> +#define REQ_CTRL_NUM_OPS_MASK GENMASK(31, 24)
> +#define REQ_CTRL_NUM_OPS(n) (REQ_CTRL_NUM_OPS_MASK & ((n) << 24))
> +#define REQ_CTRL_INITIATOR_MASK BIT(22)
> +#define REQ_CTRL_INIT0 (0x0 << 22)
> +#define REQ_CTRL_INIT1 (0x1 << 22)
pls keep spaces or tabs, not both :(
> +#define REQ_CTRL_INC_ADDR_ON BIT(21)
> +#define REQ_CTRL_DATA_SWAP_ON BIT(17)
> +#define REQ_CTRL_WNR BIT(14)
> +#define REQ_CTRL_OPCODE_MASK GENMASK(7, 4)
> +#define REQ_CTRL_OPCODE_LD_ST1 (0x0 << 4)
> +#define REQ_CTRL_OPCODE_LD_ST2 (0x1 << 4)
> +#define REQ_CTRL_OPCODE_LD_ST4 (0x2 << 4)
> +#define REQ_CTRL_OPCODE_LD_ST8 (0x3 << 4)
> +#define REQ_CTRL_OPCODE_LD_ST16 (0x4 << 4)
> +#define REQ_CTRL_OPCODE_LD_ST32 (0x5 << 4)
> +#define REQ_CTRL_OPCODE_LD_ST64 (0x6 << 4)
> +#define REQ_CTRL_HOLDOFF_MASK GENMASK(2, 0)
> +#define REQ_CTRL_HOLDOFF(n) ((n) & REQ_CTRL_HOLDOFF_MASK)
Everything here is FDMA_ so why not these as well
--
~Vinod
next prev parent reply other threads:[~2016-06-06 4:36 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 16:06 [PATCH 00/18] Add support for FDMA DMA controller and xp70 rproc found on STi chipsets Peter Griffin
2016-05-25 16:06 ` [PATCH v4 " Peter Griffin
2016-05-25 16:06 ` [PATCH v4 01/18] remoteproc: st_xp70_rproc: add a xp70 slimcore rproc driver Peter Griffin
2016-05-25 17:10 ` Bjorn Andersson
2016-06-06 7:22 ` Peter Griffin
2016-05-27 13:15 ` Patrice Chotard
[not found] ` <57484867.6030608-qxv4g6HH51o@public.gmane.org>
2016-05-27 16:13 ` Peter Griffin
2016-05-25 16:06 ` [PATCH v4 02/18] ARM: multi_v7_defconfig: enable st xp70 " Peter Griffin
2016-05-25 16:06 ` [PATCH v4 03/18] MAINTAINERS: Add st xp70 rproc driver to STi section Peter Griffin
2016-05-25 16:06 ` [PATCH v4 04/18] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Peter Griffin
[not found] ` <1464192412-16386-6-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-27 15:44 ` Rob Herring
2016-05-25 16:06 ` [PATCH v4 05/18] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file Peter Griffin
2016-06-06 4:36 ` Vinod Koul [this message]
2016-06-06 17:40 ` Peter Griffin
2016-05-25 16:06 ` [PATCH v4 06/18] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Peter Griffin
2016-05-25 17:27 ` Bjorn Andersson
[not found] ` <1464192412-16386-8-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-06-06 4:54 ` Vinod Koul
2016-06-06 17:38 ` Peter Griffin
2016-05-25 16:06 ` [PATCH v4 07/18] ARM: STi: DT: STiH407: Add FDMA driver dt nodes Peter Griffin
2016-05-25 16:06 ` [PATCH v4 08/18] MAINTAINERS: Add FDMA driver files to STi section Peter Griffin
2016-05-25 16:06 ` [PATCH v4 09/18] ARM: multi_v7_defconfig: Enable STi FDMA driver Peter Griffin
2016-05-25 16:06 ` [PATCH v4 10/18] ASoC: sti: Update DT example to match the driver code Peter Griffin
[not found] ` <1464192412-16386-12-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-27 15:47 ` Rob Herring
2016-05-27 17:14 ` Mark Brown
2016-06-03 13:05 ` Peter Griffin
2016-05-25 16:06 ` [PATCH v4 11/18] ARM: multi_v7_defconfig: Enable STi and simple-card drivers Peter Griffin
2016-05-31 8:55 ` Arnaud Pouliquen
[not found] ` <574D5178.5030200-qxv4g6HH51o@public.gmane.org>
2016-06-03 12:39 ` Peter Griffin
2016-05-25 16:06 ` [PATCH v4 12/18] ARM: DT: STiH407: Add i2s_out pinctrl configuration Peter Griffin
2016-05-25 16:06 ` [PATCH v4 13/18] ARM: DT: STiH407: Add i2s_in " Peter Griffin
2016-05-25 16:06 ` [PATCH v4 14/18] ARM: DT: STiH407: Add spdif_out pinctrl config Peter Griffin
2016-05-25 16:06 ` [PATCH v4 15/18] ARM: STi: DT: STiH407: Add sti-sasg-codec dt node Peter Griffin
2016-05-31 9:05 ` Arnaud Pouliquen
2016-06-03 13:00 ` Peter Griffin
2016-05-25 16:06 ` [PATCH v4 17/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes Peter Griffin
2016-05-31 9:18 ` Arnaud Pouliquen
[not found] ` <574D56CE.5020802-qxv4g6HH51o@public.gmane.org>
2016-06-03 12:50 ` Peter Griffin
2016-05-25 16:06 ` [PATCH v4 18/18] ARM: DT: STi: stihxxx-b2120: Add DT nodes for STi audio card Peter Griffin
2016-05-31 10:16 ` Arnaud Pouliquen
2016-06-03 12:47 ` Peter Griffin
[not found] ` <1464192412-16386-1-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-25 16:06 ` [PATCH v4 16/18] ARM: STi: DT: STiH407: Add uniperif player dt nodes Peter Griffin
[not found] ` <1464192412-16386-18-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-05-31 9:14 ` Arnaud Pouliquen
2016-06-03 12:56 ` Peter Griffin
2016-06-06 5:01 ` [PATCH 00/18] Add support for FDMA DMA controller and xp70 rproc found on STi chipsets Vinod Koul
2016-06-06 15:09 ` Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606043618.GV16910@localhost \
--to=vinod.koul@intel.com \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ludovic.barre@st.com \
--cc=maxime.coquelin@st.com \
--cc=ohad@wizery.com \
--cc=patrice.chotard@st.com \
--cc=peter.griffin@linaro.org \
--cc=srinivas.kandagatla@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).