From: Thierry Reding <thierry.reding@gmail.com>
To: Rob Herring <robh+dt@kernel.org>, Frank Rowand <frowand.list@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Russell King <linux@armlinux.org.uk>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 11/22] usb: phy: isp1301: Use of_device_match()
Date: Mon, 6 Jun 2016 10:31:53 +0200 [thread overview]
Message-ID: <20160606083204.19760-12-thierry.reding@gmail.com> (raw)
In-Reply-To: <20160606083204.19760-1-thierry.reding@gmail.com>
From: Thierry Reding <treding@nvidia.com>
This driver uses bus_find_device() to go through every platform device
and match using the driver and device tree node. It's more efficient to
use driver_find_device() to iterate over all devices associated with a
particular driver, in which case the matching is reduced to the device
tree node and can be done using the common implementation.
Signed-off-by: Thierry Reding <treding@nvidia.com>
---
drivers/usb/phy/phy-isp1301.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/usb/phy/phy-isp1301.c b/drivers/usb/phy/phy-isp1301.c
index db68156568e6..a5f5dc0b8c18 100644
--- a/drivers/usb/phy/phy-isp1301.c
+++ b/drivers/usb/phy/phy-isp1301.c
@@ -13,6 +13,7 @@
#include <linux/module.h>
#include <linux/mutex.h>
#include <linux/i2c.h>
+#include <linux/of_device.h>
#include <linux/usb/phy.h>
#include <linux/usb/isp1301.h>
@@ -138,18 +139,12 @@ static struct i2c_driver isp1301_driver = {
module_i2c_driver(isp1301_driver);
-static int match(struct device *dev, void *data)
-{
- struct device_node *node = (struct device_node *)data;
- return (dev->of_node == node) &&
- (dev->driver == &isp1301_driver.driver);
-}
-
struct i2c_client *isp1301_get_client(struct device_node *node)
{
if (node) { /* reference of ISP1301 I2C node via DT */
- struct device *dev = bus_find_device(&i2c_bus_type, NULL,
- node, match);
+ struct device *dev = driver_find_device(&isp1301_driver.driver,
+ NULL, node,
+ of_device_match);
if (!dev)
return NULL;
return to_i2c_client(dev);
--
2.8.3
next prev parent reply other threads:[~2016-06-06 8:31 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-06 8:31 [PATCH 00/22] of: Introduce of_match_device() Thierry Reding
2016-06-06 8:31 ` [PATCH 02/22] amba: tegra-ahb: Use of_device_match() Thierry Reding
2016-06-06 18:51 ` Frank Rowand
2016-06-06 8:31 ` [PATCH 03/22] coresight: " Thierry Reding
2016-06-06 8:31 ` [PATCH 04/22] i2c: core: " Thierry Reding
2016-06-06 8:31 ` [PATCH 05/22] net: cpsw-phy-sel: " Thierry Reding
2016-06-06 8:31 ` [PATCH 07/22] of/platform: " Thierry Reding
2016-06-06 8:31 ` [PATCH 08/22] spi: " Thierry Reding
2016-06-06 8:31 ` [PATCH 09/22] of: mdio: " Thierry Reding
2016-06-06 8:31 ` Thierry Reding [this message]
2016-06-06 8:31 ` [PATCH 12/22] drm/hdlcd: " Thierry Reding
[not found] ` <20160606083204.19760-1-thierry.reding-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-06-06 8:31 ` [PATCH 01/22] of: Implement of_match_device() Thierry Reding
2016-06-06 8:31 ` [PATCH 06/22] nvmem: core: Use of_device_match() Thierry Reding
2016-06-06 8:31 ` [PATCH 10/22] usb: phy: am335x-control: " Thierry Reding
2016-06-06 8:31 ` [PATCH 13/22] drm/armada: " Thierry Reding
2016-06-06 8:31 ` [PATCH 14/22] drm/etnaviv: " Thierry Reding
2016-06-06 8:31 ` [PATCH 15/22] drm/hisilicon: " Thierry Reding
2016-06-06 8:31 ` [PATCH 16/22] drm/mediatek: " Thierry Reding
2016-06-06 8:31 ` [PATCH 17/22] drm/msm: " Thierry Reding
2016-06-06 8:32 ` [PATCH 18/22] drm/rockchip: " Thierry Reding
2016-06-06 8:32 ` [PATCH 19/22] drm/sti: " Thierry Reding
2016-06-06 8:32 ` [PATCH 20/22] drm/sun4i: " Thierry Reding
2016-06-06 8:32 ` [PATCH 21/22] drm/tilcdc: " Thierry Reding
2016-06-06 8:32 ` [PATCH 22/22] iommu/mediatek: " Thierry Reding
2016-06-06 18:50 ` [PATCH 00/22] of: Introduce of_match_device() Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160606083204.19760-12-thierry.reding@gmail.com \
--to=thierry.reding@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).