From: Boris Brezillon <boris.brezillon@free-electrons.com>
To: Meng Yi <meng.yi@nxp.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
devicetree <devicetree@vger.kernel.org>,
Xiubo Li <lixiubo@cmss.chinamobile.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Nicolas Ferre <nicolas.ferre@atmel.com>,
Huan Wang <alison.wang@nxp.com>,
Emil Velikov <emil.l.velikov@gmail.com>,
ML dri-devel <dri-devel@lists.freedesktop.org>,
Rob Herring <robh+dt@kernel.org>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Kumar Gala <galak@codeaurora.org>,
Maxime Ripard <maxime.ripard@free-electrons.com>,
Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>,
Jianwei Wang <jianwei.wang.chn@gmail.com>
Subject: Re: [PATCH v5 1/2] drm/bridge: Add sii902x driver
Date: Tue, 7 Jun 2016 07:31:59 +0200 [thread overview]
Message-ID: <20160607073159.20541da1@bbrezillon> (raw)
In-Reply-To: <HE1PR04MB10516B0A27EEBFDA8019C1A1EC5D0@HE1PR04MB1051.eurprd04.prod.outlook.com>
Hi Meng,
On Tue, 7 Jun 2016 02:40:56 +0000
Meng Yi <meng.yi@nxp.com> wrote:
> Hi Boris,
>
> Sorry for reply late, I was on PTO. And another PTO on June 9~11, 2016.UTC+8
>
> >
> > > > + gpiod_set_value(sii902x->reset_gpio, 1);
> > > > +
> > > > + msleep(100);
> > > Ouch that is some juicy number. Can we get a comment with
> > > reasoning/origin of it ?
> >
> > As already explained to Maxime, I just don't know why this is needed, simply
> > because I don't have access to the datasheet and I just based my
> > implementation on another driver.
> > I can add a comment stating that this was extracted from another
> > implementation, but with no explanation on why this is needed.
> >
> > Meng, do you have any information about startup-time, or something like that?
> >
>
> I had checked the datasheet of sii9022a, which said the Min of TRESET is 100 μs, and Max is not specified.
Oh, thanks a lot. treset-min is exactly what I needed.
Regards,
Boris
--
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-06-07 5:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-02 15:00 [PATCH v5 1/2] drm/bridge: Add sii902x driver Boris Brezillon
2016-06-02 15:00 ` [PATCH v5 2/2] drm/bridge: Add sii902x DT bindings doc Boris Brezillon
2016-06-02 21:47 ` [PATCH v5 1/2] drm/bridge: Add sii902x driver Enric Balletbo Serra
[not found] ` <CAFqH_51mfuTsRKOYtiyTkQT0pbRnWJdHdeXdHGFKaGzPXujEZw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-03 6:56 ` Boris Brezillon
[not found] ` <1464879601-30569-1-git-send-email-boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2016-06-03 9:38 ` Emil Velikov
2016-06-03 10:02 ` Boris Brezillon
2016-06-03 15:04 ` Emil Velikov
2016-06-07 2:40 ` Meng Yi
2016-06-07 5:31 ` Boris Brezillon [this message]
[not found] ` <CACvgo51VRL=Ewbvx-sbwfLoPm00rDUEJ3mvk8Rc0T4WKC=UThA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-06-03 11:15 ` Alexandre Belloni
2016-06-03 13:20 ` Lucas Stach
2016-06-07 8:28 ` Meng Yi
2016-06-07 8:57 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607073159.20541da1@bbrezillon \
--to=boris.brezillon@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=alison.wang@nxp.com \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=emil.l.velikov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=jianwei.wang.chn@gmail.com \
--cc=lixiubo@cmss.chinamobile.com \
--cc=mark.rutland@arm.com \
--cc=maxime.ripard@free-electrons.com \
--cc=meng.yi@nxp.com \
--cc=nicolas.ferre@atmel.com \
--cc=pawel.moll@arm.com \
--cc=plagnioj@jcrosoft.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).