From: Bjorn Andersson <bjorn.andersson-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Peter Griffin <peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org,
maxime.coquelin-qxv4g6HH51o@public.gmane.org,
patrice.chotard-qxv4g6HH51o@public.gmane.org,
srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
arnaud.pouliquen-qxv4g6HH51o@public.gmane.org,
arnd-r2nGTMty4D4@public.gmane.org,
lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v5 01/18] remoteproc: make rsc table support optional
Date: Tue, 7 Jun 2016 12:56:17 -0700 [thread overview]
Message-ID: <20160607195617.GI1256@tuxbot> (raw)
In-Reply-To: <1465316352-20691-2-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
On Tue 07 Jun 09:18 PDT 2016, Peter Griffin wrote:
> Some firmware and rproc drivers such as slim core don't have a
> resource table. To avoid having to fudge an empty table
> in the rproc driver this patch introduces a new has_rsctable
> flag. rproc drivers which don't require a rsc table can set
> this flag to false, and it avoids doing the initial async
> firmware load in rproc_add_virtio_devices() to parse the
> rsc table during rproc_add(), and also optimises rproc_fw_boot()
> code path to avoid unnecessary rsc table processing of an
> empty table.
>
> Signed-off-by: Peter Griffin <peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Hi Peter,
Thanks for the patch. I do however dislike the amount of conditionals
already in these code paths, so I'm not in favour of adding more.
Please revert back to providing a dummy table from your driver and let's
handle this topic separate of this series.
Regards,
Bjorn
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-07 19:56 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-07 16:18 [PATCH v5 00/18] Add support for FDMA DMA controller and slim core rproc found on STi chipsets Peter Griffin
2016-06-07 16:18 ` [PATCH v5 01/18] remoteproc: make rsc table support optional Peter Griffin
2016-06-07 17:35 ` kbuild test robot
[not found] ` <1465316352-20691-2-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-06-07 19:56 ` Bjorn Andersson [this message]
[not found] ` <1465316352-20691-1-git-send-email-peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2016-06-07 16:18 ` [PATCH v5 02/18] remoteproc: st_slim_rproc: add a slimcore rproc driver Peter Griffin
2016-06-07 17:20 ` kbuild test robot
2016-06-07 16:19 ` [PATCH v5 09/18] ARM: multi_v7_defconfig: Enable STi FDMA driver Peter Griffin
2016-06-07 16:19 ` [PATCH v5 12/18] ARM: DT: STiH407: Add i2s_out pinctrl configuration Peter Griffin
2016-06-07 16:19 ` [PATCH v5 15/18] ARM: STi: DT: STiH407: Add sti-sasg-codec dt node Peter Griffin
2016-06-07 16:19 ` [PATCH v5 16/18] ARM: STi: DT: STiH407: Add uniperif player dt nodes Peter Griffin
2016-06-07 16:19 ` [PATCH v5 18/18] ARM: DT: STi: stihxxx-b2120: Add DT nodes for STi audio card Peter Griffin
2016-06-07 16:18 ` [PATCH v5 03/18] MAINTAINERS: Add st slim core rproc driver to STi section Peter Griffin
2016-06-07 16:18 ` [PATCH v5 04/18] dmaengine: st_fdma: Add STMicroelectronics FDMA DT binding documentation Peter Griffin
2016-06-07 16:18 ` [PATCH v5 05/18] dmaengine: st_fdma: Add STMicroelectronics FDMA driver header file Peter Griffin
2016-06-07 16:19 ` [PATCH v5 06/18] dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support Peter Griffin
2016-06-07 16:19 ` [PATCH v5 07/18] ARM: STi: DT: STiH407: Add FDMA driver dt nodes Peter Griffin
2016-06-07 16:19 ` [PATCH v5 08/18] MAINTAINERS: Add FDMA driver files to STi section Peter Griffin
2016-06-07 16:19 ` [PATCH v5 10/18] ASoC: sti: Update DT example to match the driver code Peter Griffin
2016-06-07 16:19 ` [PATCH v5 11/18] ARM: multi_v7_defconfig: Enable STi and simple-card drivers Peter Griffin
2016-06-07 16:19 ` [PATCH v5 13/18] ARM: DT: STiH407: Add i2s_in pinctrl configuration Peter Griffin
2016-06-07 16:19 ` [PATCH v5 14/18] ARM: DT: STiH407: Add spdif_out pinctrl config Peter Griffin
2016-06-07 16:19 ` [PATCH v5 17/18] ARM: STi: DT: STiH407: Add uniperif reader dt nodes Peter Griffin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160607195617.GI1256@tuxbot \
--to=bjorn.andersson-qsej5fyqhm4dnm+yrofe0a@public.gmane.org \
--cc=arnaud.pouliquen-qxv4g6HH51o@public.gmane.org \
--cc=arnd-r2nGTMty4D4@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=dmaengine-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=kernel-F5mvAk5X5gdBDgjK7y7TUQ@public.gmane.org \
--cc=lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-remoteproc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=maxime.coquelin-qxv4g6HH51o@public.gmane.org \
--cc=patrice.chotard-qxv4g6HH51o@public.gmane.org \
--cc=peter.griffin-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=srinivas.kandagatla-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=vinod.koul-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).