Re: [PATCH] drivers: of: Fix of_pci.h header guard

[Rob Herring <robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

On Tue, Jun 07, 2016 at 06:44:48PM +0100, Robin Murphy wrote:
> The compilation of of_pci.c is governed by CONFIG_OF_PCI, but the
> corresponding declarations in of_pci.h are inconsistently guarded by
> CONFIG_OF, with the result that if CONFIG_PCI is disabled for an OF
> platform, the dangling external declarations are still active and the
> inline stub definitions not. So far this has managed to go unnoticed
> since it happens that the only references to these functions are from
> code which itself depends on CONFIG_PCI or CONFIG_OF_PCI.
> 
> Fix this with the appropriate config guard so that any new callers
> outside PCI-specific code don't start unexpectedly breaking under
> certain configs.
> 
> Signed-off-by: Robin Murphy <robin.murphy-5wv7dgnIgG8@public.gmane.org>
> ---
>  include/linux/of_pci.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Rob
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html