public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Liu Gang <Gang.Liu@nxp.com>
Cc: devicetree@vger.kernel.org, leoyang.li@nxp.com,
	minghuan.lian@nxp.com, linux-arm-kernel@lists.infradead.org,
	scott.wood@nxp.com, shawnguo@kernel.org, mingkai.hu@nxp.com
Subject: Re: [PATCH] PCI: layerscape: Add 'dma-coherent' property
Date: Wed, 8 Jun 2016 14:54:43 -0500	[thread overview]
Message-ID: <20160608195443.GA7766@rob-hp-laptop> (raw)
In-Reply-To: <1465282546-28256-1-git-send-email-Gang.Liu@nxp.com>

On Tue, Jun 07, 2016 at 02:55:45PM +0800, Liu Gang wrote:
> Add 'dma-coherent' description for PCI nodes.
> 
> The 'dma-coherent' indicates that the hardware IP block can ensure
> the coherency of the data transferred from/to the IP block. This
> can avoid the software cache flush/invalid actions, and improve
> the performance significantly.
> 
> The PCI IP block of ls1043a has this capability, so adding
> this feature to improve the PCI performance.
> 
> Signed-off-by: Liu Gang <Gang.Liu@nxp.com>
> ---
>  Documentation/devicetree/bindings/pci/layerscape-pci.txt | 4 ++++
>  1 file changed, 4 insertions(+)

Acked-by: Rob Herring <robh@kernel.org>

> 
> diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> index ef683b2..41e9f55 100644
> --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> @@ -24,6 +24,9 @@ Required properties:
>    The first entry must be a link to the SCFG device node
>    The second entry must be '0' or '1' based on physical PCIe controller index.
>    This is used to get SCFG PEXN registers
> +- dma-coherent: Indicates that the hardware IP block can ensure the coherency
> +  of the data transferred from/to the IP block. This can avoid the software
> +  cache flush/invalid actions, and improve the performance significantly.
>  
>  Example:
>  
> @@ -38,6 +41,7 @@ Example:
>  		#address-cells = <3>;
>  		#size-cells = <2>;
>  		device_type = "pci";
> +		dma-coherent;
>  		num-lanes = <4>;
>  		bus-range = <0x0 0xff>;
>  		ranges = <0x81000000 0x0 0x00000000 0x40 0x00010000 0x0 0x00010000   /* downstream I/O */
> -- 
> 2.1.0.27.g96db324
> 

  parent reply	other threads:[~2016-06-08 19:54 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-07  6:55 [PATCH] PCI: layerscape: Add 'dma-coherent' property Liu Gang
2016-06-07  6:55 ` [PATCH] arm64: dts: ls1043a: Add 'dma-coherent' for ls1043a PCI nodes Liu Gang
2016-06-08 20:31   ` Scott Wood
2016-06-12  3:00     ` Gang Liu
2016-06-08 19:54 ` Rob Herring [this message]
     [not found] ` <1465282546-28256-1-git-send-email-Gang.Liu-3arQi8VN3Tc@public.gmane.org>
2016-06-07 10:03   ` [PATCH] PCI: layerscape: Add 'dma-coherent' property Robin Murphy
2016-06-16  0:43   ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160608195443.GA7766@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=Gang.Liu@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=leoyang.li@nxp.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=minghuan.lian@nxp.com \
    --cc=mingkai.hu@nxp.com \
    --cc=scott.wood@nxp.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox