From: Shawn Guo <shawnguo@kernel.org>
To: Damien Riegel <damien.riegel@savoirfairelinux.com>
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Mark Rutland <mark.rutland@arm.com>,
Pawel Moll <pawel.moll@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Russell King <linux@armlinux.org.uk>,
Rob Herring <robh+dt@kernel.org>,
kernel@savoirfairelinux.com, Sascha Hauer <kernel@pengutronix.de>,
Kumar Gala <galak@codeaurora.org>
Subject: Re: [PATCH 1/2] ARM: dts: TS-4800: add FPGA's IRQ controller support
Date: Thu, 9 Jun 2016 21:25:16 +0800 [thread overview]
Message-ID: <20160609132516.GA19473@tiger> (raw)
In-Reply-To: <1463516190-10606-1-git-send-email-damien.riegel@savoirfairelinux.com>
On Tue, May 17, 2016 at 04:16:29PM -0400, Damien Riegel wrote:
> Enable FPGA's IRQ controller. It is in charge of dispatching interrupts
> generated by IPs in the FPGA. The SoC is notified that an interrupt
> occurred through a GPIO.
>
> Signed-off-by: Damien Riegel <damien.riegel@savoirfairelinux.com>
> ---
> arch/arm/boot/dts/imx51-ts4800.dts | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/arch/arm/boot/dts/imx51-ts4800.dts b/arch/arm/boot/dts/imx51-ts4800.dts
> index 0ff76a1..2c89988 100644
> --- a/arch/arm/boot/dts/imx51-ts4800.dts
> +++ b/arch/arm/boot/dts/imx51-ts4800.dts
> @@ -149,6 +149,19 @@
> #size-cells = <1>;
> ranges = <0 0 0 0x1d000>;
>
> + fpga_irqc: fpga_irqc@0,15000 {
Please use hyphen rather than underscore in node name. Also
why do we need '0,' in unit-address?
> + compatible = "technologic,ts4800-irqc";
> + reg = <0x15000 0x1000>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_interrupt_fpga>;
> +
Drop this newline.
> + interrupt-parent = <&gpio2>;
> + interrupts= <9 IRQ_TYPE_LEVEL_HIGH>;
> +
Ditto
Shawn
> + interrupt-controller;
> + #interrupt-cells = <1>;
> + };
> +
> syscon: syscon@b0010000 {
> compatible = "syscon", "simple-mfd";
> reg = <0x10000 0x3d>;
> @@ -228,6 +241,12 @@
> >;
> };
>
> + pinctrl_interrupt_fpga: fpgaicgrp {
> + fsl,pins = <
> + MX51_PAD_EIM_D27__GPIO2_9 0xe5
> + >;
> + };
> +
> pinctrl_lcd: lcdgrp {
> fsl,pins = <
> MX51_PAD_DISP1_DAT0__DISP1_DAT0 0x5
> --
> 2.5.0
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2016-06-09 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 20:16 [PATCH 1/2] ARM: dts: TS-4800: add FPGA's IRQ controller support Damien Riegel
[not found] ` <1463516190-10606-1-git-send-email-damien.riegel-4ysUXcep3aM1wj+D4I0NRVaTQe2KTcn/@public.gmane.org>
2016-05-17 20:16 ` [PATCH 2/2] ARM: dts: TS-4800: add CAN support Damien Riegel
2016-06-09 13:30 ` Shawn Guo
2016-06-09 13:25 ` Shawn Guo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160609132516.GA19473@tiger \
--to=shawnguo@kernel.org \
--cc=damien.riegel@savoirfairelinux.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=kernel@pengutronix.de \
--cc=kernel@savoirfairelinux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).