From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Hans de Goede <hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
Cc: Chen-Yu Tsai <wens-jdAy2FN1RRM@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
devicetree <devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 0/1] ARM: dts: sunxi: Fix simplefb not working in 4.7-rc1
Date: Mon, 13 Jun 2016 10:01:24 +0200 [thread overview]
Message-ID: <20160613080124.GA4481@lukather> (raw)
In-Reply-To: <21258fc0-0250-951b-2ee7-d022fb3c09ac-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1705 bytes --]
On Thu, Jun 09, 2016 at 12:47:36PM +0200, Hans de Goede wrote:
> Hi,
>
> On 09-06-16 09:46, Maxime Ripard wrote:
> >Hi Hans,
> >
> >On Sat, Jun 04, 2016 at 08:05:23PM +0200, Hans de Goede wrote:
> >>Hi Maxime,
> >>
> >>While testing 4.7-rc1 / linux-sunxi/sunxi-next on a A10s I noticed that
> >>hdmi out is no longer working (screen goes black when the kernel turns
> >>of unused clocks).
> >>
> >>This is caused by the dtsi for sun4i / sun5i / sun7i based boards now
> >>listing pll3, without pll3 being added to the clocks list for the
> >>simplefb nodes.
> >
> >Why not do just that then? It's more appropriate for a fix imho.
>
> You mean just for sun5i-a10s, or for all of sun4i / sun5i-a10s and
> sun7i ?
>
> For sun4i and sun7i things are already fixed in next:
>
> https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?id=5a7f2310cc847a73852e70bc720a61ca9bf986a6
> https://git.kernel.org/cgit/linux/kernel/git/mripard/linux.git/commit/?id=c79255ca4d7b67cce4eac4dd532e097ce49f3679
>
> It seems best to use those fixes, rather then come up with a separate
> fix for 4.7.
>
> My patch for fixing sun5i-a10s is inline with the 2 above patches,
> which seems best, rather then doing something special for just sun5i-a10s.
Well, you are doing something special for just the A10s: the patches
quoted above just add a bunch of clocks and add the handles to the
list of clocks managed by simplefb.
For the A10s, you also declare the whole display engine block without
anyone having tested that it was actually working.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-06-13 8:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-04 18:05 [PATCH 0/1] ARM: dts: sunxi: Fix simplefb not working in 4.7-rc1 Hans de Goede
[not found] ` <1465063524-4925-1-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-04 18:05 ` [PATCH] ARM: dts: sun5i: Move display blocks to sun5i.dtsi Hans de Goede
[not found] ` <1465063524-4925-2-git-send-email-hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-08 15:28 ` Peter Korsgaard
2016-06-09 7:46 ` [PATCH 0/1] ARM: dts: sunxi: Fix simplefb not working in 4.7-rc1 Maxime Ripard
2016-06-09 10:47 ` Hans de Goede
[not found] ` <21258fc0-0250-951b-2ee7-d022fb3c09ac-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-13 8:01 ` Maxime Ripard [this message]
2016-06-13 8:30 ` Hans de Goede
[not found] ` <1a9a0d76-5bbf-4b79-abee-1c9dd0436567-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2016-06-20 7:46 ` Maxime Ripard
2016-06-20 20:56 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160613080124.GA4481@lukather \
--to=maxime.ripard-wi1+55scjutkeb57/3fjtnbpr1lh4cv8@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=wens-jdAy2FN1RRM@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).