From: Rob Herring <robh@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Greg Hackmann <ghackmann@google.com>,
Arnd Bergmann <arnd@arndb.de>,
Markus Pargmann <mpa@pengutronix.de>,
Olof Johansson <olof@lixom.net>,
Brian Norris <computersforpeace@gmail.com>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>,
Lee Campbell <leecam@google.com>, Tony Luck <tony.luck@intel.com>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH v4 0/1] pstore/ram: add Device Tree bindings
Date: Tue, 14 Jun 2016 16:59:15 -0500 [thread overview]
Message-ID: <20160614215914.GA16454@rob-hp-laptop> (raw)
In-Reply-To: <1465599059-22665-1-git-send-email-keescook@chromium.org>
On Fri, Jun 10, 2016 at 03:50:58PM -0700, Kees Cook wrote:
> This is a "v4" of Greg Hackmann's DT bindings for ramoops. This is
> what I'm going to land in the pstore tree unless there are strong and
> convincing arguments against it. :)
>
> I made a number of changes based people's feedback, and I want to get
> it unblocked. This patch is already carried by Android, and it doesn't
> need to be out of tree.
>
> To respond to Arnd's comment: I like this as the ramoops node, not the
> pstore node, since it describes the ramoops backend, not the pstore
> subsystem, which has different controls, and can only have one backend
> at a time. So it doesn't make sense to me to have this have a redundant
> extra pstore node, since the very presence of ramoops implies pstore.
Either I don't follow or you don't get Arnd's comment...
IIRC, his suggestion which I agree with was to remove the memory-region
phandle and just move all the properties into the reserved memory node
directly. This simplifies things such that we are just describing
properties of a chunk of memory rather than a Linux specific node for
virtual driver.
Rob
next prev parent reply other threads:[~2016-06-14 21:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-10 22:50 [PATCH v4 0/1] pstore/ram: add Device Tree bindings Kees Cook
2016-06-10 22:50 ` [PATCH v4] " Kees Cook
2016-06-14 21:59 ` Rob Herring [this message]
2016-06-15 4:40 ` [PATCH v4 0/1] " Kees Cook
2016-06-21 20:41 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160614215914.GA16454@rob-hp-laptop \
--to=robh@kernel.org \
--cc=anton@enomsg.org \
--cc=arnd@arndb.de \
--cc=ccross@android.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=ghackmann@google.com \
--cc=keescook@chromium.org \
--cc=leecam@google.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpa@pengutronix.de \
--cc=olof@lixom.net \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox