From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lee Jones Subject: Re: [PATCH v2 1/4] mfd: cros_ec: Add cros_ec_cmd_xfer_status helper Date: Thu, 16 Jun 2016 16:30:32 +0100 Message-ID: <20160616153032.GC21702@dell> References: <1464916904-37554-1-git-send-email-briannorris@chromium.org> <1464916904-37554-2-git-send-email-briannorris@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: <1464916904-37554-2-git-send-email-briannorris@chromium.org> Sender: linux-kernel-owner@vger.kernel.org To: Brian Norris Cc: Thierry Reding , Olof Johansson , linux-kernel@vger.kernel.org, Doug Anderson , Brian Norris , linux-pwm@vger.kernel.org, devicetree@vger.kernel.org, Boris Brezillon , Stephen Barber , Javier Martinez Canillas , Benson Leung , Enric Balletbo , Randall Spangler , Shawn Nematbakhsh , Dmitry Torokhov , Todd Broch , Gwendal Grignou , Tomeu Vizoso List-Id: devicetree@vger.kernel.org On Thu, 02 Jun 2016, Brian Norris wrote: > From: Tomeu Vizoso >=20 > So that callers of cros_ec_cmd_xfer don't have to repeat boilerplate > code when checking for errors from the EC side. >=20 > Signed-off-by: Tomeu Vizoso > Reviewed-by: Benson Leung > Signed-off-by: Brian Norris > --- > v2: no change >=20 > drivers/platform/chrome/cros_ec_proto.c | 15 +++++++++++++++ > include/linux/mfd/cros_ec.h | 18 ++++++++++++++++++ > 2 files changed, 33 insertions(+) >=20 > diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platfo= rm/chrome/cros_ec_proto.c > index b6e161f71b26..ecc544c728f0 100644 > --- a/drivers/platform/chrome/cros_ec_proto.c > +++ b/drivers/platform/chrome/cros_ec_proto.c > @@ -380,3 +380,18 @@ int cros_ec_cmd_xfer(struct cros_ec_device *ec_d= ev, > return ret; > } > EXPORT_SYMBOL(cros_ec_cmd_xfer); > + > +int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev, > + struct cros_ec_command *msg) > +{ > + int ret; > + > + ret =3D cros_ec_cmd_xfer(ec_dev, msg); > + if (ret < 0) > + dev_err(ec_dev->dev, "Command xfer error (err:%d)\n", ret); > + else if (msg->result !=3D EC_RES_SUCCESS) > + return -EECRESULT - msg->result; > + > + return ret; > +} > +EXPORT_SYMBOL(cros_ec_cmd_xfer_status); > diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.= h > index 64184d27e3cd..b1e48dfbf50a 100644 > --- a/include/linux/mfd/cros_ec.h > +++ b/include/linux/mfd/cros_ec.h > @@ -40,6 +40,9 @@ > #define EC_MAX_REQUEST_OVERHEAD 1 > #define EC_MAX_RESPONSE_OVERHEAD 2 > =20 > +/* ec_command return value for non-success result from EC */ > +#define EECRESULT 1000 > + > /* > * Command interface between EC and AP, for LPC, I2C and SPI interfa= ces. > */ > @@ -226,6 +229,21 @@ int cros_ec_cmd_xfer(struct cros_ec_device *ec_d= ev, > struct cros_ec_command *msg); > =20 > /** > + * cros_ec_cmd_xfer_status - Send a command to the ChromeOS EC > + * > + * This function is identical to cros_ec_cmd_xfer, except it returns= succes s/succes/success/ I guess whoever takes this patch can do a quick fix-up job on it, so: Acked-by: Lee Jones > + * status only if both the command was transmitted successfully and = the EC > + * replied with success status. It's not necessary to check msg->res= ult when > + * using this function. > + * > + * @ec_dev: EC device > + * @msg: Message to write > + * @return: Num. of bytes transferred on success, <0 on failure > + */ > +int cros_ec_cmd_xfer_status(struct cros_ec_device *ec_dev, > + struct cros_ec_command *msg); > + > +/** > * cros_ec_remove - Remove a ChromeOS EC > * > * Call this to deregister a ChromeOS EC, then clean up any private = data. --=20 Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org =E2=94=82 Open source software for ARM SoCs =46ollow Linaro: Facebook | Twitter | Blog