From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports while USB suspend Date: Mon, 20 Jun 2016 10:52:05 +0200 Message-ID: <20160620085205.GN5809@piout.net> References: <1465359311-14544-1-git-send-email-wenyou.yang@atmel.com> <1465359311-14544-2-git-send-email-wenyou.yang@atmel.com> <20160608202651.GA23604@rob-hp-laptop> <20160608203810.GF2466@piout.net> <20160617135448.GI5809@piout.net> <20160620080334.GL5809@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Yang, Wenyou" Cc: Rob Herring , Alan Stern , Greg Kroah-Hartman , "Ferre, Nicolas" , Pawel Moll , Mark Brown , Ian Campbell , Kumar Gala , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On 20/06/2016 at 08:46:02 +0000, Yang, Wenyou wrote : > Hi Alexandre & Nicolas, >=20 > > -----Original Message----- > > From: Alexandre Belloni [mailto:alexandre.belloni-wi1+55ScJUtKEb57/3fJTGGXanvQGlWp@public.gmane.org= m] > > Sent: 2016=E5=B9=B46=E6=9C=8820=E6=97=A5 16:04 > > To: Yang, Wenyou > > Cc: Rob Herring ; Alan Stern ; > > Greg Kroah-Hartman ; Ferre, Nicolas > > ; Pawel Moll ; Mark Br= own > > ; Ian Campbell ;= Kumar > > Gala ; linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; > > devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org; linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org; l= inux- > > usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > Subject: Re: [PATCH v3 1/2] usb: ohci-at91: Forcibly suspend ports = while USB > > suspend > >=20 > > On 20/06/2016 at 03:16:35 +0000, Yang, Wenyou wrote : > > > > Sure, what I mean is that you can try to get the regmap for the= SFR in every > > case. > > > > Depending on whether you were able to get it, you can decide to= call > > > > ohci_at91_port_suspend/resume or not (just test for sfr_regmap = !=3D NULL). > > > > > > I don't think so. The SFR includes a lot of miscellaneous functio= ns, more than > > this one. > > > > >=20 > > I know but this is irrelevant to this discussion. If you need to us= e the SFR from > > another driver you will simply get it from that other driver. > >=20 > > I that case, you will try to get "atmel,sama5d2-sfr". It is only pr= esent on sama5d2 > > so you have enough information to know whether or not you can use i= t to > > suspend/resume. >=20 > I understand what your meaning :). > Use "atmel,sama5d2-sfr" compatible to distinguish whether forcibly su= spend USB port via SFR or not. >=20 > I am not sure if it is a better solution. >=20 It is definitively superior. There is only one lookup in the device tre= e instead of two because whatever happens, you will have to get the SFR regmap and you don't need to add a compatible string for an IP that didn't change. > Nicolas, could you give your opinion? >=20 > >=20 > > -- > > Alexandre Belloni, Free Electrons > > Embedded Linux, Kernel and Android engineering http://free-electron= s.com >=20 >=20 > Best Regards, > Wenyou Yang --=20 Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html