public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Chris Lapa <chris@lapa.com.au>
Cc: k.kozlowski@samsung.com, dwmw2@infradead.org,
	dbaryshkov@gmail.com, sre@kernel.org, mark.rutland@arm.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH v3 1/7] max8903: adds documentation for device tree bindings.
Date: Mon, 20 Jun 2016 08:22:47 -0500	[thread overview]
Message-ID: <20160620132247.GA30380@rob-hp-laptop> (raw)
In-Reply-To: <1466139626-51434-2-git-send-email-chris@lapa.com.au>

On Fri, Jun 17, 2016 at 03:00:20PM +1000, Chris Lapa wrote:
> From: Chris Lapa <chris@lapa.com.au>
> 
> Signed-off-by: Chris Lapa <chris@lapa.com.au>
> ---
>  .../devicetree/bindings/power/max8903-charger.txt  | 25 ++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/max8903-charger.txt
> 
> diff --git a/Documentation/devicetree/bindings/power/max8903-charger.txt b/Documentation/devicetree/bindings/power/max8903-charger.txt
> new file mode 100644
> index 0000000..aea1dd2a
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/max8903-charger.txt
> @@ -0,0 +1,25 @@
> +Maxim Semiconductor MAX8903 Battery Charger bindings
> +
> +Required properties:
> +- compatible: "maxim,max8903-charger" for MAX8903 Battery Charger

Drop "charger" as that is implied by the chip.

> +- dok-gpios: Valid DC power has been detected, optional if uok-gpios is provided
> +- uok-gpios: Valid USB power has been detected, optional if dok-gpios is provided
> +
> +Optional properties:
> +- cen-gpios: Charge enable pin
> +- chg-gpios: Charger status pin
> +- flt-gpios: Fault pin
> +- dcm-gpios: Current limit mode setting (DC or USB)
> +- usus-gpios: USB suspend pin

Need to state direction and active state for all of these.

  parent reply	other threads:[~2016-06-20 13:22 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1464849897-21527-3-git-send-email-chris@lapa.com.au>
2016-06-10 12:32 ` [PATCH v2 0/4] max8903: Add device tree support and logic fixup Chris Lapa
2016-06-10 12:32   ` [PATCH v2 1/4] max8903: adds documentation for device tree bindings Chris Lapa
2016-06-10 13:51     ` Krzysztof Kozlowski
2016-06-14  1:54       ` Chris Lapa
2016-06-16  6:35         ` Krzysztof Kozlowski
2016-06-16  6:48           ` Chris Lapa
2016-06-10 12:32   ` [PATCH v2 2/4] max8903: adds support for initiation via device tree Chris Lapa
2016-06-10 14:02     ` Krzysztof Kozlowski
2016-06-14  1:50       ` Chris Lapa
2016-06-10 12:32   ` [PATCH v2 3/4] max8903: cleans up confusing relationship between dc_valid, dok and dcm Chris Lapa
2016-06-10 12:32   ` [PATCH v2 4/4] max8903: remove unnecessary malloc failed message print out Chris Lapa
2016-06-10 14:08     ` Krzysztof Kozlowski
2016-06-17  5:00 ` [PATCH v3 0/7] max8903: Add device tree support and misc fixes Chris Lapa
     [not found]   ` <1466139626-51434-1-git-send-email-chris-oDmnclXj83W6c6uEtOJ/EA@public.gmane.org>
     [not found]     ` <1464849897-21527-3-git-send-email-chris-oDmnclXj83W6c6uEtOJ/EA@public.gmane.org>
2016-06-17  5:00       ` [PATCH v3 4/7] max8903: adds requesting of gpios Chris Lapa
2016-06-17  6:30         ` Krzysztof Kozlowski
2016-06-19 13:51           ` Chris Lapa
2016-06-17  5:00       ` [PATCH v3 5/7] max8903: removes non zero validity checks on gpios Chris Lapa
2016-06-17  6:35         ` Krzysztof Kozlowski
2016-06-19 22:27       ` [PATCH v4 0/7] max8903: Add device tree support and misc fixes Chris Lapa
2016-06-19 22:27       ` [PATCH v4 5/7] max8903: removes non zero validity checks on gpios Chris Lapa
2016-06-20 12:21         ` Krzysztof Kozlowski
2016-06-17  5:00 ` [PATCH v3 1/7] max8903: adds documentation for device tree bindings Chris Lapa
2016-06-17  6:15   ` Krzysztof Kozlowski
2016-06-20 13:22   ` Rob Herring [this message]
2016-06-20 23:43     ` Chris Lapa
2016-06-17  5:00 ` [PATCH v3 2/7] max8903: store pointer to pdata instead of copying it Chris Lapa
2016-06-17  6:14   ` Krzysztof Kozlowski
2016-06-17  5:00 ` [PATCH v3 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm Chris Lapa
2016-06-17  6:23   ` Krzysztof Kozlowski
2016-06-17  6:26   ` Krzysztof Kozlowski
2016-06-17  6:28     ` Chris Lapa
2016-06-17  6:42       ` Krzysztof Kozlowski
2016-06-19 13:48     ` Chris Lapa
2016-06-17  5:00 ` [PATCH v3 6/7] max8903: remove unnecessary 'out of memory' error message Chris Lapa
2016-06-17  6:35   ` Krzysztof Kozlowski
2016-06-17  5:00 ` [PATCH v3 7/7] max8903: adds support for initiation via device tree Chris Lapa
2016-06-17  6:41   ` Krzysztof Kozlowski
2016-06-19 13:52     ` Chris Lapa
2016-06-19 22:27 ` [PATCH v4 1/7] max8903: adds documentation for device tree bindings Chris Lapa
2016-06-20 12:17   ` Krzysztof Kozlowski
2016-06-19 22:27 ` [PATCH v4 2/7] max8903: store pointer to pdata instead of copying it Chris Lapa
2016-06-20 12:18   ` Krzysztof Kozlowski
2016-06-19 22:27 ` [PATCH v4 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm Chris Lapa
2016-06-20 12:18   ` Krzysztof Kozlowski
2016-06-19 22:27 ` [PATCH v4 4/7] max8903: adds requesting of gpios Chris Lapa
2016-06-20 12:20   ` Krzysztof Kozlowski
2016-06-19 22:27 ` [PATCH v4 6/7] max8903: remove unnecessary 'out of memory' error message Chris Lapa
2016-06-20 12:22   ` Krzysztof Kozlowski
2016-06-19 22:27 ` [PATCH v4 7/7] max8903: adds support for initiation via device tree Chris Lapa
     [not found]   ` <1466375242-38354-8-git-send-email-chris-DtE7ei5U7Kg0n/F98K4Iww@public.gmane.org>
2016-06-20 12:23     ` Krzysztof Kozlowski
2016-06-24  2:26 ` [PATCH v5 0/7] max8903: Add device tree support and misc fixes Chris Lapa
2016-06-28 18:16   ` Sebastian Reichel
2016-06-28 23:05     ` Chris Lapa
2016-06-24  2:26 ` [PATCH v5 1/7] max8903: adds documentation for device tree bindings Chris Lapa
2016-06-28 20:55   ` Rob Herring
2016-06-24  2:26 ` [PATCH v5 2/7] max8903: store pointer to pdata instead of copying it Chris Lapa
2016-06-24  2:26 ` [PATCH v5 3/7] max8903: cleans up confusing relationship between dc_valid, dok and dcm Chris Lapa
2016-06-24  2:26 ` [PATCH v5 4/7] max8903: adds requesting of gpios Chris Lapa
2016-06-24  2:26 ` [PATCH v5 5/7] max8903: removes non zero validity checks on gpios Chris Lapa
2016-06-24  2:26 ` [PATCH v5 6/7] max8903: remove unnecessary 'out of memory' error message Chris Lapa
2016-06-24  2:26 ` [PATCH v5 7/7] max8903: adds support for initiation via device tree Chris Lapa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160620132247.GA30380@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=chris@lapa.com.au \
    --cc=dbaryshkov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dwmw2@infradead.org \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox