From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Herring Subject: Re: [PATCH v2 1/3] Documentation: DT: Add iproc-static-adc binding Date: Mon, 20 Jun 2016 13:04:58 -0500 Message-ID: <20160620180458.GA10171@rob-hp-laptop> References: <1466330790-2820-1-git-send-email-raveendra.padasalagi@broadcom.com> <1466330790-2820-2-git-send-email-raveendra.padasalagi@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1466330790-2820-2-git-send-email-raveendra.padasalagi-dY08KVG/lbpWk0Htik3J/w@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Raveendra Padasalagi Cc: Jonathan Cameron , Peter Meerwald-Stadler , Russell King , Arnd Bergmann , linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jonathan Richardson , Jon Mason , Florian Fainelli , Anup Patel , Ray Jui , Scott Branden , Pramod Kumar , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org List-Id: devicetree@vger.kernel.org On Sun, Jun 19, 2016 at 03:36:28PM +0530, Raveendra Padasalagi wrote: > The patch adds devicetree binding document for broadcom's > iproc-static-adc controller driver. > > Signed-off-by: Raveendra Padasalagi > Reviewed-by: Ray Jui > Reviewed-by: Scott Branden > --- > .../bindings/iio/adc/brcm,iproc-static-adc.txt | 43 ++++++++++++++++++++++ > 1 file changed, 43 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt > > diff --git a/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt > new file mode 100644 > index 0000000..1de0dfa > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/brcm,iproc-static-adc.txt > @@ -0,0 +1,43 @@ > +* Broadcom's IPROC Static ADC controller > + > +Required properties: > + > +- compatible: Must be "brcm,iproc-static-adc" > + > +- #address-cells: Specify the number of u32 entries needed in child nodes. > + Should set to 1. > + > +- #size-cells: Specify number of u32 entries needed to specify child nodes size > + in reg property. Should set to 1. Why are these needed? What child nodes can you have? > + > +- adc-syscon: Handler of syscon node defining physical base address of the > + controller and length of memory mapped region. > + > +- #io-channel-cells = <1>; As ADC has multiple outputs > + refer to Documentation/devicetree/bindings/iio/iio-bindings.txt for details. > + > +- clocks: Clock used for this block. > + > +- clock-names: Clock name should be given as tsc_clk. > + > +- interrupts: interrupt line number. > + > +For example: > + > + ts_adc_syscon: ts_adc_syscon@180a6000 { > + compatible = "brcm,iproc-ts-adc-syscon","syscon"; > + reg = <0x180a6000 0xc30>; > + }; > + > + adc: adc@180a6000 { > + compatible = "brcm,iproc-static-adc"; > + #address-cells = <1>; > + #size-cells = <1>; > + adc-syscon = <&ts_adc_syscon>; > + #io-channel-cells = <1>; > + io-channel-ranges; > + clocks = <&asiu_clks BCM_CYGNUS_ASIU_ADC_CLK>; > + clock-names = "tsc_clk"; > + interrupts = ; > + status = "disabled"; > + }; > -- > 1.9.1 >