From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Chen Subject: Re: [PATCH 07/12] power: pwrseq: rename file name for generic driver Date: Tue, 21 Jun 2016 10:19:49 +0800 Message-ID: <20160621021949.GF26936@shlinux2> References: <1466158165-9380-1-git-send-email-peter.chen@nxp.com> <1466158165-9380-8-git-send-email-peter.chen@nxp.com> <5767E614.5030002@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <5767E614.5030002@samsung.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Krzysztof Kozlowski Cc: mark.rutland@arm.com, Peter Chen , ulf.hansson@linaro.org, stephen.boyd@linaro.org, festevam@gmail.com, arnd@arndb.de, javier@osg.samsung.com, stern@rowland.harvard.edu, devicetree@vger.kernel.org, mail@maciej.szmigiero.name, pawel.moll@arm.com, linux-pm@vger.kernel.org, s.hauer@pengutronix.de, troy.kisky@boundarydevices.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, oscar@naiandei.net, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-mmc@vger.kernel.org, sre@kernel.org, broonie@kernel.org, p.zabel@pengutronix.de List-Id: devicetree@vger.kernel.org On Mon, Jun 20, 2016 at 02:48:20PM +0200, Krzysztof Kozlowski wrote: > On 06/17/2016 12:09 PM, Peter Chen wrote: > > The individual driver file name is better to contain module name. > > > > Signed-off-by: Peter Chen > > --- > > .../power/pwrseq/{pwrseq-simple.txt => mmc-pwrseq-simple.txt} | 0 > > drivers/power/pwrseq/Makefile | 4 ++-- > > drivers/power/pwrseq/{pwrseq.c => core.c} | 0 > > drivers/power/pwrseq/{pwrseq_simple.c => pwrseq_mmc_simple.c} | 0 > > 4 files changed, 2 insertions(+), 2 deletions(-) > > rename Documentation/devicetree/bindings/power/pwrseq/{pwrseq-simple.txt => mmc-pwrseq-simple.txt} (100%) > > rename drivers/power/pwrseq/{pwrseq.c => core.c} (100%) > > rename drivers/power/pwrseq/{pwrseq_simple.c => pwrseq_mmc_simple.c} (100%) > > > > diff --git a/Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt b/Documentation/devicetree/bindings/power/pwrseq/mmc-pwrseq-simple.txt > > similarity index 100% > > rename from Documentation/devicetree/bindings/power/pwrseq/pwrseq-simple.txt > > rename to Documentation/devicetree/bindings/power/pwrseq/mmc-pwrseq-simple.txt > > diff --git a/drivers/power/pwrseq/Makefile b/drivers/power/pwrseq/Makefile > > index 9e40e4b..d475e01 100644 > > --- a/drivers/power/pwrseq/Makefile > > +++ b/drivers/power/pwrseq/Makefile > > @@ -1,3 +1,3 @@ > > -obj-$(CONFIG_POWER_SEQ) += pwrseq.o > > -obj-$(CONFIG_POWER_SEQ_SIMPLE) += pwrseq_simple.o > > +obj-$(CONFIG_POWER_SEQ) += core.o > > +obj-$(CONFIG_POWER_SEQ_SIMPLE) += pwrseq_mmc_simple.o > > Although the driver was developed for MMC but it is quite generic (or > rather - mmc independent). The name of the driver is just > "pwrseq_simple" so I think MMC prefix is not needed. > It is may be common for MMC, but not USB, or others. Eg, its reset-gpios is just like enable-gpios. Some reset chip process needs to toggle gpio. -- Best Regards, Peter Chen