From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Opensource [Adam Thomson]" <Adam.Thomson.Opensource@diasemi.com>
Cc: Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
Support Opensource <Support.Opensource@diasemi.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mark Brown <broonie@kernel.org>,
"Rafael J.Wysocki" <rafael.j.wysocki@intel.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Robert Moore <robert.moore@intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>, Lv Zheng <lv.zheng@intel.com>,
Takashi Iwai <tiwai@suse.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Frank Rowand <frowand.list@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Len Brown <lenb@kernel.org>
Subject: Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device
Date: Tue, 21 Jun 2016 14:59:47 +0300 [thread overview]
Message-ID: <20160621115947.GZ1739@lahna.fi.intel.com> (raw)
In-Reply-To: <2E89032DDAA8B9408CB92943514A0337D46442AB@SW-EX-MBX01.diasemi.com>
On Tue, Jun 21, 2016 at 11:50:01AM +0000, Opensource [Adam Thomson] wrote:
> 21 June 2016 12:42, Rafael J. Wysocki wrote:
>
> > > > +static inline bool acpi_data_node_match(struct fwnode_handle *fwnode,
> > > > + const char *name)
> > > > +{
> > > > + return is_acpi_data_node(fwnode) ?
> > > > + (!strcasecmp(to_acpi_data_node(fwnode)->name, name)) : false;
> > > > +}
> > >
> > > Looks fine to me.
> > >
> > > One question - is it expected that matching ACPI data nodes is always
> > > case insensitive?
> >
> > That would not be a correct expectation in theory, although I don't think it
> > really matters in practice.
>
> From my reading of the Hierarchical Data Extension and ACPI Spec, I thought
> that was the case (section 19.3.1 ASL Names - ASL names are not case-sensitive
> and will be converted to upper case). Am I misreading the documents/missing
> something else?
Those are names in the ASL code itself.
What we are talking here are actually just string values (name of the
data node).
next prev parent reply other threads:[~2016-06-21 11:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 11:38 [RESEND PATCH v3 0/2] ASoC: da7219: Convert driver to use generic FW functions Adam Thomson
2016-06-20 11:38 ` [RESEND PATCH v3 1/2] device property: Add function to search for named child of device Adam Thomson
2016-06-21 10:20 ` Opensource [Adam Thomson]
2016-06-21 10:22 ` Andy Shevchenko
2016-06-21 10:39 ` Opensource [Adam Thomson]
[not found] ` <866c9edccdd89805f6a0c0aa92f8a78ae616ed61.1466421714.git.Adam.Thomson.Opensource-WBD+wuPFNBhBDgjK7y7TUQ@public.gmane.org>
2016-06-21 11:11 ` Mika Westerberg
2016-06-21 11:42 ` Rafael J. Wysocki
2016-06-21 11:50 ` Opensource [Adam Thomson]
2016-06-21 11:59 ` Mika Westerberg [this message]
2016-06-21 12:27 ` Opensource [Adam Thomson]
2016-06-21 14:07 ` Opensource [Adam Thomson]
[not found] ` <2E89032DDAA8B9408CB92943514A0337D46442AB-68WUHU125fLLPO1uwJ3ImwLouzNaz+3S@public.gmane.org>
2016-06-21 15:11 ` Rafael J. Wysocki
2016-06-21 11:54 ` Mika Westerberg
2016-06-20 11:38 ` [RESEND PATCH v3 2/2] ASoC: da7219: Convert driver to use generic device/fwnode functions Adam Thomson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160621115947.GZ1739@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=Adam.Thomson.Opensource@diasemi.com \
--cc=Support.Opensource@diasemi.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=lenb@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.zheng@intel.com \
--cc=rafael.j.wysocki@intel.com \
--cc=rjw@rjwysocki.net \
--cc=robert.moore@intel.com \
--cc=robh+dt@kernel.org \
--cc=sathyanarayana.nujella@intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).