From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Westerberg Subject: Re: [RESEND PATCH v3 1/2] device property: Add function to search for named child of device Date: Tue, 21 Jun 2016 14:59:47 +0300 Message-ID: <20160621115947.GZ1739@lahna.fi.intel.com> References: <866c9edccdd89805f6a0c0aa92f8a78ae616ed61.1466421714.git.Adam.Thomson.Opensource@diasemi.com> <20160621111126.GX1739@lahna.fi.intel.com> <28758107.YROb1rVtm6@vostro.rjw.lan> <2E89032DDAA8B9408CB92943514A0337D46442AB@SW-EX-MBX01.diasemi.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <2E89032DDAA8B9408CB92943514A0337D46442AB@SW-EX-MBX01.diasemi.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: "Opensource [Adam Thomson]" Cc: Sathyanarayana Nujella , "devicetree@vger.kernel.org" , "alsa-devel@alsa-project.org" , Heikki Krogerus , Support Opensource , Greg Kroah-Hartman , Mark Brown , "Rafael J.Wysocki" , "Rafael J. Wysocki" , Robert Moore , Liam Girdwood , "linux-acpi@vger.kernel.org" , Rob Herring , Lv Zheng , Takashi Iwai , Andy Shevchenko , Frank Rowand , "linux-kernel@vger.kernel.org" , Len Brown List-Id: devicetree@vger.kernel.org On Tue, Jun 21, 2016 at 11:50:01AM +0000, Opensource [Adam Thomson] wrote: > 21 June 2016 12:42, Rafael J. Wysocki wrote: > > > > > +static inline bool acpi_data_node_match(struct fwnode_handle *fwnode, > > > > + const char *name) > > > > +{ > > > > + return is_acpi_data_node(fwnode) ? > > > > + (!strcasecmp(to_acpi_data_node(fwnode)->name, name)) : false; > > > > +} > > > > > > Looks fine to me. > > > > > > One question - is it expected that matching ACPI data nodes is always > > > case insensitive? > > > > That would not be a correct expectation in theory, although I don't think it > > really matters in practice. > > From my reading of the Hierarchical Data Extension and ACPI Spec, I thought > that was the case (section 19.3.1 ASL Names - ASL names are not case-sensitive > and will be converted to upper case). Am I misreading the documents/missing > something else? Those are names in the ASL code itself. What we are talking here are actually just string values (name of the data node).