From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexandre Belloni Subject: Re: [PATCH v2 4/4] rtc: rv8803: Be able to set VDETOFF and SWOFF via devcie tree Date: Fri, 24 Jun 2016 09:44:07 +0200 Message-ID: <20160624074407.GJ5809@piout.net> References: <1466577742-18824-1-git-send-email-dirk.behme@de.bosch.com> <1466577742-18824-5-git-send-email-dirk.behme@de.bosch.com> Reply-To: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <1466577742-18824-5-git-send-email-dirk.behme-V5te9oGctAVWk0Htik3J/w@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Dirk Behme Cc: rtc-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Oleksij Rempel , Carsten Resch List-Id: devicetree@vger.kernel.org On 22/06/2016 at 08:42:22 +0200, Dirk Behme wrote : > From: Oleksij Rempel > > There might be designs where the power supply circuit is designed > in a way that VDETOFF and SWOFF is reuqired to be set. Otherwise the > RTC detects a power loss. Add a device tree interface for this. > > Signed-off-by: Carsten Resch > Signed-off-by: Dirk Behme > Signed-off-by: Oleksij Rempel > Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > --- > drivers/rtc/rtc-rv8803.c | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/drivers/rtc/rtc-rv8803.c b/drivers/rtc/rtc-rv8803.c > index e122b51..32a5686 100644 > --- a/drivers/rtc/rtc-rv8803.c > +++ b/drivers/rtc/rtc-rv8803.c > @@ -50,6 +50,10 @@ > #define RV8803_CTRL_TIE BIT(4) > #define RV8803_CTRL_UIE BIT(5) > > +#define RX8900_BACKUP_CTRL 0x18 > +#define RX8900_FLAG_SWOFF BIT(2) > +#define RX8900_FLAG_VDETOFF BIT(3) > + > struct rv8803_data { > struct i2c_client *client; > struct rtc_device *rtc; > @@ -423,6 +427,35 @@ static struct rtc_class_ops rv8803_rtc_ops = { > .ioctl = rv8803_ioctl, > }; > > +static int rx8900_trickle_charger_init(struct rv8803_data *rv8803) > +{ > + struct i2c_client *client = rv8803->client; > + struct device_node *node = client->dev.of_node; > + int err; > + u8 flags; > + > + if (!node) > + return 0; > + > + if (!of_device_is_compatible(node, "epson,rx8900")) > + return 0; > + Can you use the i2c_device_id instead of of_device_is_compatible to avoid matching on yet another string? -- Alexandre Belloni, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.