Re: [PATCH 07/12] dt-bindings: i2c: Add support for 'i2c-bus' subnode

Jon Hunter
2016-06-29T08:05:49Z

On 28/06/16 22:32, Wolfram Sang wrote:
> * PGP Signed by an unknown key
>
>> For
>> example some Tegra devices have an I2C interface which may share its
>> pins with other devices and to share these pins subnodes for
>> representing these pins so they have be shared via the pinctrl framework
>> are needed.
>
> I think the above sentence is hard to grasp. Can you split it into more
> sentences perhaps?

OK, yes does seem a bit of a mouthful.

>> +- i2c-bus
>> + For I2C adapters that have child nodes that are a mixture of both I2C
>> + devices and non-I2C devices (such as a pin controller), the 'i2c-bus'
>
> I suggest to drop the phrase in the paranthesis. It is true for your
> case, but I don't think it's generic. So, it is not an obvious example
> like "Yes, sure, I see that a pin controller has I2C nodes and non-I2C
> nodes". At least for me, it was more like "It has what?"

OK, will drop that part.

Cheers
Jon

--
nvpublic
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org