From mboxrd@z Thu Jan 1 00:00:00 1970 From: Maxime Ripard Subject: Re: [PATCH v2 13/14] ARM: dts: sun8i: Add gpio-regulator used on Orange Pi One Date: Sat, 25 Jun 2016 09:18:09 +0200 Message-ID: <20160625071808.GE4000@lukather> References: <20160625034511.7966-1-megous@megous.com> <20160625034511.7966-14-megous@megous.com> Reply-To: maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="zaRBsRFn0XYhEU69" Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org Content-Disposition: inline In-Reply-To: <20160625034511.7966-14-megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org Cc: dev-3kdeTeqwOZ9EV1b7eY7vFQ@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, Rob Herring , Mark Rutland , Russell King , Chen-Yu Tsai , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list List-Id: devicetree@vger.kernel.org --zaRBsRFn0XYhEU69 Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline On Sat, Jun 25, 2016 at 05:45:10AM +0200, megous-5qf/QAjKc83QT0dZR+AlfA@public.gmane.org wrote: > From: Ondrej Jirman > > Xulong Orange Pi One uses GPIO based regulator that > switches between two voltages: 1.1V and 1.3V. The > regulator is controlled from the PL6 pin. > > Signed-off-by: Ondrej Jirman > --- > v2 > - add missing pinctrl-names for gpio-regulator > --- > arch/arm/boot/dts/sun8i-h3-orangepi-one.dts | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > index 0adf932..b1bd6b0 100644 > --- a/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > +++ b/arch/arm/boot/dts/sun8i-h3-orangepi-one.dts > @@ -88,6 +88,25 @@ > gpios = <&r_pio 0 3 GPIO_ACTIVE_LOW>; > }; > }; > + > + vdd_soc: gpio-regulator { > + compatible = "regulator-gpio"; > + pinctrl-names = "default"; > + pinctrl-0 = <&vdd_reg_r_opc>; > + > + regulator-name = "soc-vdd-supply"; > + regulator-min-microvolt = <1100000>; > + regulator-max-microvolt = <1300000>; > + regulator-boot-on; > + regulator-type = "voltage"; It should be marked as always-on. Otherwise, if the cpufreq driver is not enabled, the regulator will be shutdown, which is not that great :) Maxime -- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com --zaRBsRFn0XYhEU69--