From: Pavel Machek <pavel@ucw.cz>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: Florian Vaussard <florian.vaussard@gmail.com>,
devicetree@vger.kernel.org, Richard Purdie <rpurdie@rpsys.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
Florian Vaussard <florian.vaussard@heig-vd.ch>
Subject: Re: [PATCH 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver
Date: Sun, 26 Jun 2016 23:49:02 +0200 [thread overview]
Message-ID: <20160626214902.GB21026@amd> (raw)
In-Reply-To: <57695D45.60107@samsung.com>
Hi!
> >+struct ncp5623_led {
> >+ bool active;
> >+ unsigned int led_no;
> >+ struct led_classdev ldev;
> >+ struct work_struct work;
> >+ struct ncp5623_priv *priv;
> >+};
> >+
> >+struct ncp5623_priv {
> >+ struct ncp5623_led leds[NCP5623_MAX_LEDS];
>
> Please allocate memory dynamically, depending on the number
> of LEDs defined in a Device Tree.
MAX_LEDs is three. Are you sure overhead of dynamic allocation is
worth it?
And if this is for RGB leds... very probably device will want to use
all 3 channels.
Best regards,
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2016-06-26 21:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-21 7:29 [PATCH 0/2] leds: Add driver for NCP5623 3-channel I2C LED driver Florian Vaussard
[not found] ` <1466494154-3786-1-git-send-email-florian.vaussard-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
2016-06-21 7:29 ` [PATCH 1/2] leds: ncp5623: Add device tree binding documentation Florian Vaussard
2016-06-21 15:28 ` Jacek Anaszewski
2016-06-22 6:08 ` Florian Vaussard
2016-06-22 8:51 ` Jacek Anaszewski
[not found] ` <576A5191.4070402-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2016-06-22 14:25 ` Florian Vaussard
[not found] ` <c97adf5a-7c5b-8602-83c1-f85854bd64d6-EWQkb/GNqlFyDzI6CaY1VQ@public.gmane.org>
2016-06-23 7:23 ` Jacek Anaszewski
2016-06-23 8:32 ` Florian Vaussard
2016-06-23 11:21 ` Jacek Anaszewski
2016-06-23 12:01 ` Florian Vaussard
2016-06-23 13:53 ` Jacek Anaszewski
2016-06-22 8:52 ` Jacek Anaszewski
2016-06-21 21:52 ` Rob Herring
2016-06-22 6:17 ` Florian Vaussard
2016-06-21 7:29 ` [PATCH 2/2] leds: Add driver for NCP5623 3-channel I2C LED driver Florian Vaussard
2016-06-21 15:29 ` Jacek Anaszewski
2016-06-22 6:08 ` Florian Vaussard
2016-06-22 7:26 ` Jacek Anaszewski
2016-06-26 21:49 ` Pavel Machek [this message]
2016-06-27 5:46 ` Florian Vaussard
2016-06-27 7:09 ` Jacek Anaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160626214902.GB21026@amd \
--to=pavel@ucw.cz \
--cc=devicetree@vger.kernel.org \
--cc=florian.vaussard@gmail.com \
--cc=florian.vaussard@heig-vd.ch \
--cc=j.anaszewski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).