Re: [PATCH v2 2/4] dt/bindings: Add bindings for Micro Crystal rv8803

[Alexandre Belloni <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>]

On 29/06/2016 at 06:34:58 +0200, fixed-term.Oleksij.Rempel wrote :
> 
> 
> On 24.06.2016 21:14, Andrey Smirnov wrote:
> > On Fri, Jun 24, 2016 at 12:48 AM, Alexandre Belloni
> > <alexandre.belloni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org> wrote:
> >> On 22/06/2016 at 08:42:20 +0200, Dirk Behme wrote :
> >>> From: Oleksij Rempel <fixed-term.Oleksij.Rempel-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
> >>>
> >>> ... and Epson RX8900 real time clock
> >>>
> >>> Signed-off-by: Oleksij Rempel <fixed-term.Oleksij.Rempel-V5te9oGctAVWk0Htik3J/w@public.gmane.org>
> >>> Cc: devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> >>> ---
> >>>  .../devicetree/bindings/rtc/epson,rx8900.txt       | 22 ++++++++++++++++++++++
> >>>  1 file changed, 22 insertions(+)
> >>>  create mode 100644 Documentation/devicetree/bindings/rtc/epson,rx8900.txt
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/rtc/epson,rx8900.txt b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt
> >>> new file mode 100644
> >>> index 0000000..3f61e51
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/rtc/epson,rx8900.txt
> >>> @@ -0,0 +1,22 @@
> >>> +Real Time Clock driver for:
> >>> +  - Epson RX8900
> >>> +  - Micro Crystal rv8803
> >>> +
> >>> +Required properties:
> >>> +- compatible: should be: "microcrystal,rv8803" or "epson,rx8900"
> >>> +- reg : the I2C address of the device for I2C
> >>> +
> >>> +Optional properties:
> >>> +- epson,vdet-disable : boolean, if present will disable voltage detector.
> >>> +  Should be set if no backup battery is used.
> >>
> >> I guess we need to make that one generic. I would use
> >> voltage-detection-disable.
> >>
> >> Andrey, can you use that one instead of
> >> dallas,disable-oscillator-stop-flag ?
> >>
> > 
> > AFAIU from reading RX8900 datasheet, it has two power rails main and a
> > backup one, so setting this property disables circuitry responsible
> > for detecting main power rail failure and switching to a backup one.
> > 
> > DS1341 has only one power rail and setting
> > "dallas,disable-oscillator-stop-flag" will disable circuitry
> > responsible for detection of failure of the oscillator ticking its
> > internal clock.
> > 
> > IMHO, those functionalities don't have much in common and using the
> > same property would be confusing for users of that binding on DS1341,
> > but it's a boolean so there's not technical reason I couldn't.
> 
> Should i still replace epson,vdet-disable to voltage-detection-disable?

No, Andrey is right.

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.