From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: "mark.rutland@arm.com" <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"emilio@elopez.com.ar" <emilio@elopez.com.ar>,
"mturquette@baylibre.com" <mturquette@baylibre.com>,
"sboyd@codeaurora.org" <sboyd@codeaurora.org>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"edubezval@gmail.com" <edubezval@gmail.com>,
"wens@csie.org" <wens@csie.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"rui.zhang@intel.com" <rui.zhang@intel.com>,
"linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33
Date: Wed, 29 Jun 2016 14:10:21 +0200 [thread overview]
Message-ID: <20160629121021.GD6095@lukather> (raw)
In-Reply-To: <60021467122182@web19j.yandex.ru>
[-- Attachment #1.1: Type: text/plain, Size: 955 bytes --]
Hi,
On Tue, Jun 28, 2016 at 09:56:22PM +0800, Icenowy Zheng wrote:
> The reason for a dedicate driver is:
> 1. This IP have only thermal function, so it's not suitable to use a
> driver at drivers/input/touchscreen/.
That's not a problem, and it's being worked on [1].
> 2. Control Register are quite different.
That's not a problem either, there's just a bit that you don't need to
set in the control 1 register, and that's pretty much it. It doesn't
justify a whole new driver.
> 3. This IP uses AUDIO PLL (PLL2) as its clock!
It's listed as the input, but all the rest of the documentation refers
only to 24MHz, which seems to indicate that it's only running on the
oscillator, which would make much more sense.
Thanks,
Maxime
1: http://lists.infradead.org/pipermail/linux-arm-kernel/2016-June/439487.html
--
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-06-29 12:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 10:13 [RFC PATCH 1/5] clk: sunxi: Add a driver for the PLL2 on A31/23/33 Icenowy Zheng
2016-06-28 10:13 ` [RFC PATCH 2/5] dt: bindings: add bindings for allwinner a23/33 ths Icenowy Zheng
2016-06-28 10:13 ` [RFC PATCH 3/5] thermal: Add support for the thermal sensor on A23/33 Icenowy Zheng
2016-06-28 11:46 ` Maxime Ripard
2016-06-28 13:56 ` Icenowy Zheng
2016-06-29 12:10 ` Maxime Ripard [this message]
2016-06-29 13:31 ` Icenowy Zheng
2016-06-29 13:42 ` Maxime Ripard
2016-06-29 13:52 ` Icenowy Zheng
2016-06-29 13:33 ` Icenowy Zheng
2016-06-29 13:42 ` Icenowy Zheng
2016-06-28 14:03 ` Icenowy Zheng
2016-06-28 10:13 ` [RFC PATCH 4/5] ARM: sun8i: enable PLL2 on a23/33 Icenowy Zheng
2016-06-28 10:13 ` [RFC PATCH 5/5] ARM: sun8i: enable ths node for A23/33 Icenowy Zheng
2016-07-05 6:12 ` [RFC PATCH 1/5] clk: sunxi: Add a driver for the PLL2 on A31/23/33 Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160629121021.GD6095@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=edubezval@gmail.com \
--cc=emilio@elopez.com.ar \
--cc=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=mturquette@baylibre.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=sboyd@codeaurora.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).