devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* mtd: nand: omap2: check for elm_id removed
@ 2016-07-04 12:51 Teresa Remmet
       [not found] ` <1467636717.4618.19.camel-wipSkzokR0f8DgGbXC/JcDlJRLeN4+xs@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Teresa Remmet @ 2016-07-04 12:51 UTC (permalink / raw)
  To: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-omap-u79uwXL29TY76Z2rM5mHXA
  Cc: tony-4v6yS6AI5VpBDgjK7y7TUQ, Roger Quadros,
	boris.brezillon-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8,
	computersforpeace-Re5JQEeQqe8AvxtiuMwx3w

Hello,

with commit c9711ec5250b22fd94e9b34c17c095e001a90e66
("mtd: nand: omap: Clean up device tree support")
the old "elm_id" property check has been removed. So only "ti,elm-id" is
valid now.
I noticed that the old property is still used by 3 boards:

git grep elm_id arch/arm/boot/dts/*
arch/arm/boot/dts/am335x-baltos.dtsi:           elm_id = <&elm>;
arch/arm/boot/dts/am335x-igep0033.dtsi:         elm_id = <&elm>;
arch/arm/boot/dts/am335x-phycore-som.dtsi:              elm_id = <&elm>;

I wonder if the right way would be to patch the device trees, or to add
the check again and to keep backward compatibility?

I may provide a patch then.

Regards,
Teresa

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: mtd: nand: omap2: check for elm_id removed
       [not found] ` <1467636717.4618.19.camel-wipSkzokR0f8DgGbXC/JcDlJRLeN4+xs@public.gmane.org>
@ 2016-07-04 13:01   ` Boris Brezillon
  0 siblings, 0 replies; 2+ messages in thread
From: Boris Brezillon @ 2016-07-04 13:01 UTC (permalink / raw)
  To: Teresa Remmet
  Cc: devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-mtd-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	linux-omap-u79uwXL29TY76Z2rM5mHXA, tony-4v6yS6AI5VpBDgjK7y7TUQ,
	Roger Quadros, computersforpeace-Re5JQEeQqe8AvxtiuMwx3w

On Mon, 04 Jul 2016 14:51:57 +0200
Teresa Remmet <t.remmet-guT5V/WYfQezQB+pC5nmwQ@public.gmane.org> wrote:

> Hello,
> 
> with commit c9711ec5250b22fd94e9b34c17c095e001a90e66
> ("mtd: nand: omap: Clean up device tree support")
> the old "elm_id" property check has been removed. So only "ti,elm-id" is
> valid now.
> I noticed that the old property is still used by 3 boards:
> 
> git grep elm_id arch/arm/boot/dts/*
> arch/arm/boot/dts/am335x-baltos.dtsi:           elm_id = <&elm>;
> arch/arm/boot/dts/am335x-igep0033.dtsi:         elm_id = <&elm>;
> arch/arm/boot/dts/am335x-phycore-som.dtsi:              elm_id = <&elm>;
> 
> I wonder if the right way would be to patch the device trees, or to add
> the check again and to keep backward compatibility?

We should probably do both, though backward compat is usually dependent
on the platform maintainer (some accept to break DT backward compat).

Anyway, all DTs should be patched to use the new binding, so you can at
least send a patch doing that.

> 
> I may provide a patch then.
> 
> Regards,
> Teresa
> 

--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-07-04 13:01 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-04 12:51 mtd: nand: omap2: check for elm_id removed Teresa Remmet
     [not found] ` <1467636717.4618.19.camel-wipSkzokR0f8DgGbXC/JcDlJRLeN4+xs@public.gmane.org>
2016-07-04 13:01   ` Boris Brezillon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).