From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
Russell King <linux@armlinux.org.uk>,
open list <linux-kernel@vger.kernel.org>,
Ettore Chimenti <ettore.chimenti@udoo.org>,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Fabio Estevam <fabio.estevam@nxp.com>,
Shawn Guo <shawnguo@kernel.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] ARM: dts: imx6sx: Add UDOO Neo support
Date: Tue, 5 Jul 2016 08:27:36 +0200 [thread overview]
Message-ID: <20160705062736.GL16643@pengutronix.de> (raw)
In-Reply-To: <1467691450-22975-3-git-send-email-afaerber@suse.de>
Hello,
On Tue, Jul 05, 2016 at 06:04:09AM +0200, Andreas Färber wrote:
> +&iomuxc {
> + imx6sx-udoo-neo {
There is no need for this machine group. Please just put the pinctrl
groups directly into &iomuxc { }.
> + pinctrl_enet1: enet1grp {
> + fsl,pins =
> + <MX6SX_PAD_ENET1_CRS__GPIO2_IO_1 0xa0b1>,
> + <MX6SX_PAD_ENET1_MDC__ENET1_MDC 0xa0b1>,
It's unusual to write pinmuxes this way. The usual form is to write it
in a single array. (Not sure I'm using the right term here.) Having said
that I like it your way, but still it should (IMHO) get a more official
blessing.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
next prev parent reply other threads:[~2016-07-05 6:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 4:04 [PATCH 0/3] ARM: dts: imx6sx: Initial UDOO Neo enablement Andreas Färber
2016-07-05 4:04 ` [PATCH 1/3] ARM: dts: imx6sx-sabreauto: Fix misspelled property Andreas Färber
[not found] ` <1467691450-22975-2-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-07-05 8:54 ` Sudeep Holla
2016-08-08 13:58 ` Shawn Guo
2016-07-05 4:04 ` [PATCH 2/3] ARM: dts: imx6sx: Add UDOO Neo support Andreas Färber
2016-07-05 6:27 ` Uwe Kleine-König [this message]
[not found] ` <20160705062736.GL16643-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-07-05 14:46 ` Andreas Färber
[not found] ` <1467691450-22975-3-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-07-05 12:04 ` Fabio Estevam
2016-07-05 13:55 ` Andreas Färber
2016-07-05 18:33 ` Uwe Kleine-König
2016-08-08 14:04 ` Shawn Guo
[not found] ` <1467691450-22975-1-git-send-email-afaerber-l3A5Bk7waGM@public.gmane.org>
2016-07-05 4:04 ` [PATCH 3/3] ARM: dts: imx6sx-udoo-neo: Add SD Andreas Färber
2016-08-08 14:12 ` Shawn Guo
2016-08-08 15:00 ` Andreas Färber
[not found] ` <16912a4e-88c8-b11a-16bb-927ee6bf1775-l3A5Bk7waGM@public.gmane.org>
2016-08-15 12:38 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705062736.GL16643@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=afaerber@suse.de \
--cc=devicetree@vger.kernel.org \
--cc=ettore.chimenti@udoo.org \
--cc=fabio.estevam@nxp.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).