From: Maxime Ripard <maxime.ripard@free-electrons.com>
To: Icenowy Zheng <icenowy@aosc.xyz>
Cc: mark.rutland@arm.com, boris.brezillon@free-electrons.com,
devicetree@vger.kernel.org, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org, wens@csie.org, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH -next] ARM: dts: sun8i: Add NFC node to Allwinner A23/A33 SoC
Date: Wed, 6 Jul 2016 22:29:32 +0200 [thread overview]
Message-ID: <20160706202932.GD4247@lukather> (raw)
In-Reply-To: <20160706003352.28194-1-icenowy@aosc.xyz>
[-- Attachment #1.1: Type: text/plain, Size: 1060 bytes --]
Hi,
On Wed, Jul 06, 2016 at 08:33:52AM +0800, Icenowy Zheng wrote:
> Add NAND Flash controller node definition to the A23/A33 SoC.
>
> Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
Has this ever been tested? On what board, with what NAND chip?
> ---
> arch/arm/boot/dts/sun8i-a23-a33.dtsi | 23 +++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun8i-a23-a33.dtsi b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> index 7e05e09..270c38a 100644
> --- a/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> +++ b/arch/arm/boot/dts/sun8i-a23-a33.dtsi
> @@ -209,6 +209,14 @@
> "apb2_uart3", "apb2_uart4";
> };
>
> + nand_clk: clk@01c20080 {
> + #clock-cells = <0>;
> + compatible = "allwinner,sun4i-a10-mod0-clk";
> + reg = <0x01c20080 0x4>;
> + clocks = <&osc24M>, <&pll6 1>;
> + clock-output-names = "nand";
> + };
> +
This should be in a separate patch.
Thanks!
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2016-07-06 20:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 0:33 [PATCH -next] ARM: dts: sun8i: Add NFC node to Allwinner A23/A33 SoC Icenowy Zheng
2016-07-06 20:29 ` Maxime Ripard [this message]
2016-07-07 0:04 ` Icenowy Zheng
2016-07-07 7:23 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706202932.GD4247@lukather \
--to=maxime.ripard@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=devicetree@vger.kernel.org \
--cc=icenowy@aosc.xyz \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).