devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
	Marc Zyngier <marc.zyngier@arm.com>,
	linux-pci@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org,
	Heiko Stuebner <heiko@sntech.de>,
	Doug Anderson <dianders@chromium.org>,
	Wenrui Li <wenrui.li@rock-chips.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org,
	Brian Norris <briannorris@chromium.org>
Subject: Re: [v6,2/2] PCI: Rockchip: Add Rockchip PCIe controller support
Date: Fri, 8 Jul 2016 09:35:11 -0700	[thread overview]
Message-ID: <20160708163511.GA23348@roeck-us.net> (raw)
In-Reply-To: <1467789398-13501-2-git-send-email-shawn.lin@rock-chips.com>

On Wed, Jul 06, 2016 at 03:16:38PM +0800, Shawn Lin wrote:
> This patch adds Rockchip PCIe controller support found
> on RK3399 Soc platform.
> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---

[ ... ]

> +	/* Get the I/O and memory ranges from DT */
> +	resource_list_for_each_entry(win, &res) {
> +		switch (resource_type(win->res)) {
> +		case IORESOURCE_IO:
> +			io = win->res;
> +			io->name = "I/O";
> +			io_size = resource_size(io);
> +			io_bus_addr = io->start - win->offset;
> +			err = pci_remap_iospace(io, io_base);

This function is not exported. Either it will have to be exported
(which may be difficult since it is declared as __weak), or the
driver must only be built into the kernel, or the function can
not be used.

Guenter

  parent reply	other threads:[~2016-07-08 16:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-06  7:16 [PATCH v6 1/2] Documentation: bindings: add dt doc for Rockchip PCIe controller Shawn Lin
2016-07-06  7:16 ` [PATCH v6 2/2] PCI: Rockchip: Add Rockchip PCIe controller support Shawn Lin
2016-07-07  0:12   ` Brian Norris
     [not found]     ` <20160707001254.GA100467-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-07-07  0:44       ` Brian Norris
2016-07-08 16:35   ` Guenter Roeck [this message]
     [not found]     ` <20160708163511.GA23348-0h96xk9xTtrk1uMJSBkQmQ@public.gmane.org>
2016-07-08 20:10       ` [v6,2/2] " Arnd Bergmann
2016-07-07  0:39 ` [PATCH v6 1/2] Documentation: bindings: add dt doc for Rockchip PCIe controller Brian Norris
     [not found]   ` <20160707003912.GB100467-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-07-13  1:10     ` Shawn Lin
     [not found]       ` <59b328c9-3a21-36fa-7f28-4ba24d77fef0-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-07-13  1:31         ` Brian Norris
     [not found]           ` <20160713013117.GA130126-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2016-07-13  1:45             ` Shawn Lin
     [not found]               ` <95a7ffdd-becc-bb3f-c026-d07c691b7a53-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
2016-07-13  2:05                 ` Brian Norris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160708163511.GA23348@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=arnd@arndb.de \
    --cc=bhelgaas@google.com \
    --cc=briannorris@chromium.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=heiko@sntech.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=marc.zyngier@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawn.lin@rock-chips.com \
    --cc=wenrui.li@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).