From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [v6,2/2] PCI: Rockchip: Add Rockchip PCIe controller support Date: Fri, 8 Jul 2016 09:35:11 -0700 Message-ID: <20160708163511.GA23348@roeck-us.net> References: <1467789398-13501-2-git-send-email-shawn.lin@rock-chips.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <1467789398-13501-2-git-send-email-shawn.lin@rock-chips.com> Sender: linux-pci-owner@vger.kernel.org To: Shawn Lin Cc: Bjorn Helgaas , Marc Zyngier , linux-pci@vger.kernel.org, Arnd Bergmann , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Heiko Stuebner , Doug Anderson , Wenrui Li , Rob Herring , devicetree@vger.kernel.org, Brian Norris List-Id: devicetree@vger.kernel.org On Wed, Jul 06, 2016 at 03:16:38PM +0800, Shawn Lin wrote: > This patch adds Rockchip PCIe controller support found > on RK3399 Soc platform. > > Signed-off-by: Shawn Lin > --- [ ... ] > + /* Get the I/O and memory ranges from DT */ > + resource_list_for_each_entry(win, &res) { > + switch (resource_type(win->res)) { > + case IORESOURCE_IO: > + io = win->res; > + io->name = "I/O"; > + io_size = resource_size(io); > + io_bus_addr = io->start - win->offset; > + err = pci_remap_iospace(io, io_base); This function is not exported. Either it will have to be exported (which may be difficult since it is declared as __weak), or the driver must only be built into the kernel, or the function can not be used. Guenter