Re: [PATCH] ARM: dts: armada-388-clearfog: remove duplicate mdio entry

[Russell King - ARM Linux <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>]

On Mon, Jul 11, 2016 at 12:27:43AM +0200, Andrew Lunn wrote:
> On Sun, Jul 10, 2016 at 09:45:46PM +0100, Russell King - ARM Linux wrote:
> > On Sun, Jul 10, 2016 at 10:37:51PM +0200, Andrew Lunn wrote:
> > > The armada-38x.dtsi has
> > > 
> > >                                 ref_clk0_pins: ref-clk-pins-0 {
> > >                                         marvell,pins = "mpp45";
> > >                                         marvell,function = "ref";
> > >                                 };
> > > 
> > > which you could reference rather then defining it yourself.
> > 
> > Weren't these going to be deleted from the main SoC dtsi files,
> > eventually?  I thought that was the idea, to prevent cluttering
> > up the .dtb files with nodes which aren't ever used.
> 
> I've not heard they are going to be removed....
> 
> Having work on mvebu, and a Freescale Vybrid board, i see two
> different styles. mvebu defines all the common pinctrl values in the
> .dtsi file, so making the .dts file pretty minimalist. For the vybrid
> board there was nothing in the .dtsi file, the dts file is huge, and i
> made at least one error, missing at required pin which took me a while
> to debug.
> 
> I would also say cluttered .dtb because of unused nodes it a compiler
> issue. Why does it not optimise them out?

How does it know that the pinmux nodes (which are nodes in their own
right, just like any node specifying a real device) are "unused" ?

It doesn't - there's no way that the compiler can possibly know that
these aren't going to be iterated over as a child of the pinctrl@18000
node.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html