public inbox for devicetree@vger.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, Alexander Shiyan <shc_work@mail.ru>,
	linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
	Mark Brown <broonie@kernel.org>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/2] spi: add DT binding for clps711x SPI
Date: Tue, 12 Jul 2016 15:49:47 -0500	[thread overview]
Message-ID: <20160712204947.GA6182@rob-hp-laptop> (raw)
In-Reply-To: <20160707094952.4111577-2-arnd@arndb.de>

On Thu, Jul 07, 2016 at 11:49:46AM +0200, Arnd Bergmann wrote:
> This documents the binding used by Alexander Shiyan's DT support for
> the clps711x SPI controller.
> 
> I've left the file name to match the ARM platform port name "clps711x"
> for consistency with the other bindings, even though the compatible
> string refers to the later ep7309 chip.
> 
> Linux no longer supports the old clps711x and ep72xx product lines,
> but we still use the name. The entire family is now discontinued
> by the manufacturer.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Alexander Shiyan <shc_work@mail.ru>
> ---
>  .../devicetree/bindings/spi/spi-clps711x.txt       | 33 ++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/spi/spi-clps711x.txt
> 
> diff --git a/Documentation/devicetree/bindings/spi/spi-clps711x.txt b/Documentation/devicetree/bindings/spi/spi-clps711x.txt
> new file mode 100644
> index 000000000000..4c3ec13f423f
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/spi/spi-clps711x.txt
> @@ -0,0 +1,33 @@
> +Serial Peripheral Interface on Cirrus Logic CL-PS71xx, EP72xx, EP73xx
> +
> +Required properties
> +- #address-cells: must be <1>
> +- #size-cells: must be <0>
> +- compatible: should include "cirrus,ep7209-spi"
> +- reg: Address and length of one register range
> +- interrupts: one interrupt line
> +- clocks: One entry, refers to the SPI bus clock
> +- cs-gpios: Specifies the gpio pins to be used for chipselects.
> +	    See: Documentation/devicetree/bindings/spi/spi-bus.txt
> +
> +An additional register is present in the system controller,
> +which is assumed to be in the same device tree, with and marked
> +as compatible with "cirrus,ep7209-syscon3".
> +
> +Example:
> +
> +spi@80000500 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +	compatible = "cirrus,ep7209-spi";
> +	reg = <0x80000500 0x4>;
> +	interrupts = <15>;
> +	clocks = <&clks CLPS711X_CLK_SPI>;
> +	status = "disabled";
> +};
> +
> +syscon3: syscon@80002200 {

This looks like it shouldn't be here.

> +	compatible = "cirrus,ep7209-syscon3", "syscon";
> +	reg = <0x80002200 0x40>;
> +};
> +
> -- 
> 2.9.0
> 

  reply	other threads:[~2016-07-12 20:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-07  9:49 [PATCH v2 1/2] spi: clps711x: Driver refactor Arnd Bergmann
     [not found] ` <20160707094952.4111577-1-arnd-r2nGTMty4D4@public.gmane.org>
2016-07-07  9:49   ` [PATCH v2 2/2] spi: add DT binding for clps711x SPI Arnd Bergmann
2016-07-12 20:49     ` Rob Herring [this message]
2016-07-13  8:13       ` Arnd Bergmann
2016-07-13  8:20         ` Alexander Shiyan
     [not found]           ` <1468398000.319627182-MSam/alRxCtsdVUOrk1QfQ@public.gmane.org>
2016-07-13  8:32             ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160712204947.GA6182@rob-hp-laptop \
    --to=robh@kernel.org \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=shc_work@mail.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox