From: Peter Chen <hzpeterchen@gmail.com>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: mark.rutland@arm.com, Peter Chen <peter.chen@nxp.com>,
ulf.hansson@linaro.org, stephen.boyd@linaro.org,
k.kozlowski@samsung.com, festevam@gmail.com,
stillcompiling@gmail.com, pawel.moll@arm.com,
stern@rowland.harvard.edu, devicetree@vger.kernel.org,
mail@maciej.szmigiero.name, arnd@arndb.de,
linux-pm@vger.kernel.org, s.hauer@pengutronix.de,
troy.kisky@boundarydevices.com, robh+dt@kernel.org,
linux-arm-kernel@lists.infradead.org, oscar@naiandei.net,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
sre@kernel.org, broonie@kernel.org, shawnguo@kernel.org
Subject: Re: [PATCH v2 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic power sequence library
Date: Wed, 13 Jul 2016 16:42:50 +0800 [thread overview]
Message-ID: <20160713084250.GB11863@shlinux2> (raw)
In-Reply-To: <1468394851.3638.13.camel@pengutronix.de>
On Wed, Jul 13, 2016 at 09:27:31AM +0200, Philipp Zabel wrote:
> Am Mittwoch, den 13.07.2016, 10:06 +0800 schrieb Peter Chen:
> > Add binding doc for generic power sequence library.
> >
> > Signed-off-by: Peter Chen <peter.chen@nxp.com>
> > ---
> > .../bindings/power/pwrseq/pwrseq-generic.txt | 53 ++++++++++++++++++++++
> > 1 file changed, 53 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/power/pwrseq/pwrseq-generic.txt
> >
> > diff --git a/Documentation/devicetree/bindings/power/pwrseq/pwrseq-generic.txt b/Documentation/devicetree/bindings/power/pwrseq/pwrseq-generic.txt
> > new file mode 100644
> > index 0000000..186c58c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/pwrseq/pwrseq-generic.txt
> > @@ -0,0 +1,53 @@
> > +The generic power sequence library
> > +
> > +Some hard-wired USB/MMC devices need to do power sequence to let the
> > +device work normally,
>
> I would replace "to let the device work normally" with "before the
> device can be enumerated [on the bus]" here.
>
Ok.
> > the typical power sequence like: enable USB
> > +PHY clock, toggle reset pin, etc. But current Linux USB driver
> > +lacks of such code to do it, it may cause some hard-wired USB devices
> > +works abnormal or can't be recognized by controller at all. The
> > +power sequence will be done before this device can be found at USB
> > +bus.
> > +
> > +The power sequence properties is under the device node.
> > +
> > +Required properties:
> > +- power-sequence: this device needs to do power sequence before enumeration
>
> As Joshua pointed out, is this even needed at all?
>
If no, how we decide whether allocates pwrseq instance through pwrseq
library or not?
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-07-13 8:42 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 2:06 [PATCH v2 0/6] power: add power sequence library Peter Chen
2016-07-13 2:06 ` [PATCH v2 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic " Peter Chen
2016-07-13 7:27 ` Philipp Zabel
2016-07-13 8:42 ` Peter Chen [this message]
2016-07-13 23:20 ` Joshua Clayton
2016-07-14 6:36 ` Peter Chen
2016-07-16 22:30 ` Rob Herring
2016-07-18 3:04 ` Peter Chen
2016-07-13 2:06 ` [PATCH v2 2/6] power: add " Peter Chen
2016-07-13 2:06 ` [PATCH v2 3/6] binding-doc: usb: usb-device: add optional properties for power sequence Peter Chen
2016-07-16 22:31 ` Rob Herring
2016-07-18 2:55 ` Peter Chen
2016-07-13 2:06 ` [PATCH v2 4/6] usb: core: add power sequence handling for USB devices Peter Chen
2016-07-13 2:06 ` [PATCH v2 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Peter Chen
[not found] ` <1468375610-18625-1-git-send-email-peter.chen-3arQi8VN3Tc@public.gmane.org>
2016-07-13 2:06 ` [PATCH v2 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node Peter Chen
2016-08-23 10:22 ` [PATCH v2 0/6] power: add power sequence library Vaibhav Hiremath
2016-08-23 10:27 ` Vaibhav Hiremath
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160713084250.GB11863@shlinux2 \
--to=hzpeterchen@gmail.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mail@maciej.szmigiero.name \
--cc=mark.rutland@arm.com \
--cc=oscar@naiandei.net \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=peter.chen@nxp.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
--cc=stephen.boyd@linaro.org \
--cc=stern@rowland.harvard.edu \
--cc=stillcompiling@gmail.com \
--cc=troy.kisky@boundarydevices.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).