From: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
To: Philipp Zabel <p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Florian Fainelli
<f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Sergei Shtylyov
<sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org>,
Geert Uytterhoeven
<geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org>
Subject: Re: [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support
Date: Thu, 14 Jul 2016 17:13:05 +0200 [thread overview]
Message-ID: <20160714151305.GH6667@lunn.ch> (raw)
In-Reply-To: <1468491528-17515-1-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> +static int ksz8041_config_init(struct phy_device *phydev)
> +{
> + /* Limit supported and advertised modes in fiber mode */
> + if (of_property_read_bool(phydev->mdio.dev.of_node, "fxen")) {
> + phydev->dev_flags |= MICREL_PHY_FXEN;
> + phydev->supported &= SUPPORTED_FIBRE |
> + SUPPORTED_100baseT_Full |
> + SUPPORTED_100baseT_Half;
> + phydev->advertising &= ADVERTISED_FIBRE |
> + ADVERTISED_100baseT_Full |
> + ADVERTISED_100baseT_Half;
Hi Philipp
Does the PHY actually advertise anything? Should phydev->advertising
be set to 0?
Andrew
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-07-14 15:13 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 10:18 [PATCH] net: phy: micrel: Add KSZ8041FTL fiber mode support Philipp Zabel
2016-07-14 11:35 ` Sergei Shtylyov
2016-07-14 13:16 ` Philipp Zabel
[not found] ` <1468491528-17515-1-git-send-email-p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2016-07-14 13:37 ` Andrew Lunn
[not found] ` <20160714133706.GF6667-g2DYL2Zd6BY@public.gmane.org>
2016-07-14 13:51 ` Philipp Zabel
2016-07-14 14:32 ` Andrew Lunn
2016-07-14 15:13 ` Andrew Lunn [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-07-14 14:29 Philipp Zabel
2016-07-14 14:33 ` Arnd Bergmann
2016-07-14 14:46 ` Philipp Zabel
2016-07-14 15:15 ` Andrew Lunn
2016-07-14 15:15 ` Arnd Bergmann
2016-07-15 18:53 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714151305.GH6667@lunn.ch \
--to=andrew-g2dyl2zd6by@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=f.fainelli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=geert-Td1EMuHUCqxL1ZNQvxDV9g@public.gmane.org \
--cc=mark.rutland-5wv7dgnIgG8@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=p.zabel-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sergei.shtylyov-M4DtvfQ/ZS1MRgGoP+s0PdBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).