From: Peter Chen <hzpeterchen@gmail.com>
To: Rajesh Bhagat <rajesh.bhagat@nxp.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Peter Chen <peter.chen@nxp.com>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"kishon@ti.com" <kishon@ti.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver
Date: Fri, 15 Jul 2016 15:13:09 +0800 [thread overview]
Message-ID: <20160715071309.GF817@shlinux2> (raw)
In-Reply-To: <HE1PR0401MB2331ED4FB7F699A8A1BA0BE6E3300@HE1PR0401MB2331.eurprd04.prod.outlook.com>
On Tue, Jul 12, 2016 at 03:59:07AM +0000, Rajesh Bhagat wrote:
> > > +
> > > +err_clks:
> > > + ci_hdrc_qoriq_disable_unprepare_clks(pdev);
> >
> > If you have only one clock, it is unnecessary to use dedicated APIs for clock operation.
> >
>
> We do have multiple clocks, but currently one is integrated in code. Hence created
> the APIs for future use.
If you could not integrate one more clocks, I suggest not creating dedicated
API until you need in future.
--
Best Regards,
Peter Chen
next prev parent reply other threads:[~2016-07-15 7:13 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 4:30 [PATCH v2 0/5] drivers: usb: chipidea: Add qoriq platform Rajesh Bhagat
[not found] ` <1468038656-10345-1-git-send-email-rajesh.bhagat-3arQi8VN3Tc@public.gmane.org>
2016-07-09 4:30 ` [PATCH v2 1/5] drivers: usb: chipidea: Add qoriq platform driver Rajesh Bhagat
2016-07-09 5:53 ` kbuild test robot
[not found] ` <1468038656-10345-2-git-send-email-rajesh.bhagat-3arQi8VN3Tc@public.gmane.org>
2016-07-09 5:59 ` kbuild test robot
2016-07-09 6:13 ` kbuild test robot
2016-07-11 6:43 ` Peter Chen
2016-07-12 3:59 ` Rajesh Bhagat
2016-07-15 7:13 ` Peter Chen [this message]
2016-07-15 8:13 ` Rajesh Bhagat
2016-07-09 4:30 ` [PATCH v2 2/5] usb: DT binding documentation for qoriq usb 2.0 controller Rajesh Bhagat
2016-07-11 6:48 ` Peter Chen
2016-07-12 3:59 ` Rajesh Bhagat
[not found] ` <HE1PR0401MB23319FBFD0D42D997A05AB34E3300-B0v07Ae2taq261RfQLkPjo3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-07-15 7:15 ` Peter Chen
2016-07-15 8:13 ` Rajesh Bhagat
[not found] ` <1468038656-10345-3-git-send-email-rajesh.bhagat-3arQi8VN3Tc@public.gmane.org>
2016-07-16 0:28 ` Rob Herring
2016-07-09 4:30 ` [PATCH v2 3/5] drivers: usb: phy: Add qoriq usb 2.0 phy driver support Rajesh Bhagat
2016-07-11 6:54 ` Peter Chen
2016-07-12 3:59 ` Rajesh Bhagat
2016-07-09 4:30 ` [PATCH v2 4/5] phy: DT binding documentation for qoriq usb 2.0 phy Rajesh Bhagat
2016-07-16 0:35 ` Rob Herring
2016-07-09 4:30 ` [PATCH v2 5/5] arm: dts: ls1021a: enable chipidea driver and USB 2.0 PHY driver Rajesh Bhagat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715071309.GF817@shlinux2 \
--to=hzpeterchen@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@nxp.com \
--cc=rajesh.bhagat@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).