devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Chen <hzpeterchen@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: Peter Chen <peter.chen@nxp.com>,
	gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
	ulf.hansson@linaro.org, broonie@kernel.org, sre@kernel.org,
	shawnguo@kernel.org, k.kozlowski@samsung.com,
	linux-arm-kernel@lists.infradead.org, p.zabel@pengutronix.de,
	devicetree@vger.kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, linux-usb@vger.kernel.org, arnd@arndb.de,
	s.hauer@pengutronix.de, mail@maciej.szmigiero.name,
	troy.kisky@boundarydevices.com, festevam@gmail.com,
	oscar@naiandei.net, stephen.boyd@linaro.org,
	linux-pm@vger.kernel.org, stillcompiling@gmail.com
Subject: Re: [PATCH v2 3/6] binding-doc: usb: usb-device: add optional properties for power sequence
Date: Mon, 18 Jul 2016 10:55:07 +0800	[thread overview]
Message-ID: <20160718025507.GC31293@shlinux2> (raw)
In-Reply-To: <20160716223158.GB8984@rob-hp-laptop>

On Sat, Jul 16, 2016 at 05:31:59PM -0500, Rob Herring wrote:
> On Wed, Jul 13, 2016 at 10:06:47AM +0800, Peter Chen wrote:
> > Add optional properties for power sequence.
> > 
> > Signed-off-by: Peter Chen <peter.chen@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/usb/usb-device.txt | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/usb/usb-device.txt b/Documentation/devicetree/bindings/usb/usb-device.txt
> > index 1c35e7b..0ccaadf 100644
> > --- a/Documentation/devicetree/bindings/usb/usb-device.txt
> > +++ b/Documentation/devicetree/bindings/usb/usb-device.txt
> > @@ -13,6 +13,10 @@ Required properties:
> >  - reg: the port number which this device is connecting to, the range
> >    is 1-31.
> >  
> > +Optional properties:
> > +power sequence properties, see
> > +Documentation/devicetree/bindings/power/pwrseq/pwrseq-generic.txt for detail
> > +
> >  Example:
> >  
> >  &usb1 {
> > @@ -24,5 +28,10 @@ Example:
> >  	hub: genesys@1 {
> >  		compatible = "usb5e3,608";
> >  		reg = <1>;
> > +
> > +		power-sequence;
> > +		clocks = <&clks IMX6SX_CLK_CKO>;
> > +		reset-gpios = <&gpio4 5 GPIO_ACTIVE_LOW>; /* hub reset pin */
> > +		reset-duration-us = <10>;
> 
> These belong in the binding doc for the hub.
> 

There is no dedicated binding doc for USB hub, we only have this binding
doc for hard-wired USB devices.

-- 

Best Regards,
Peter Chen

  reply	other threads:[~2016-07-18  2:55 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-13  2:06 [PATCH v2 0/6] power: add power sequence library Peter Chen
2016-07-13  2:06 ` [PATCH v2 1/6] binding-doc: power: pwrseq-generic: add binding doc for generic " Peter Chen
2016-07-13  7:27   ` Philipp Zabel
2016-07-13  8:42     ` Peter Chen
2016-07-13 23:20       ` Joshua Clayton
2016-07-14  6:36         ` Peter Chen
2016-07-16 22:30   ` Rob Herring
2016-07-18  3:04     ` Peter Chen
2016-07-13  2:06 ` [PATCH v2 2/6] power: add " Peter Chen
2016-07-13  2:06 ` [PATCH v2 3/6] binding-doc: usb: usb-device: add optional properties for power sequence Peter Chen
2016-07-16 22:31   ` Rob Herring
2016-07-18  2:55     ` Peter Chen [this message]
2016-07-13  2:06 ` [PATCH v2 4/6] usb: core: add power sequence handling for USB devices Peter Chen
     [not found] ` <1468375610-18625-1-git-send-email-peter.chen-3arQi8VN3Tc@public.gmane.org>
2016-07-13  2:06   ` [PATCH v2 5/6] usb: chipidea: let chipidea core device of_node equal's glue layer device of_node Peter Chen
2016-08-23 10:22   ` [PATCH v2 0/6] power: add power sequence library Vaibhav Hiremath
2016-08-23 10:27     ` Vaibhav Hiremath
2016-07-13  2:06 ` [PATCH v2 6/6] ARM: dts: imx6qdl-udoo.dtsi: fix onboard USB HUB property Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160718025507.GC31293@shlinux2 \
    --to=hzpeterchen@gmail.com \
    --cc=arnd@arndb.de \
    --cc=broonie@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mail@maciej.szmigiero.name \
    --cc=mark.rutland@arm.com \
    --cc=oscar@naiandei.net \
    --cc=p.zabel@pengutronix.de \
    --cc=pawel.moll@arm.com \
    --cc=peter.chen@nxp.com \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    --cc=sre@kernel.org \
    --cc=stephen.boyd@linaro.org \
    --cc=stern@rowland.harvard.edu \
    --cc=stillcompiling@gmail.com \
    --cc=troy.kisky@boundarydevices.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).