From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH V2] leds: trigger: Introduce an USB port trigger Date: Wed, 20 Jul 2016 10:08:08 +0200 Message-ID: <20160720080808.GB11581@amd> References: <1468239883-22695-1-git-send-email-zajec5@gmail.com> <1468617060-29830-1-git-send-email-zajec5@gmail.com> <20160718023126.GB31293@shlinux2> <20160718054010.GE31293@shlinux2> <20160718055345.GF31293@shlinux2> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: =?utf-8?B?UmFmYcWCIE1pxYJlY2tp?= Cc: Peter Chen , Richard Purdie , Jacek Anaszewski , Felipe Balbi , "linux-usb@vger.kernel.org" , Rob Herring , Mark Rutland , Jonathan Corbet , Sakari Ailus , Ezequiel Garcia , Boris Brezillon , Geert Uytterhoeven , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , "open list:DOCUMENTATION" , "open list:LED SUBSYSTEM" List-Id: devicetree@vger.kernel.org On Mon 2016-07-18 08:55:52, Rafa=C5=82 Mi=C5=82ecki wrote: > On 18 July 2016 at 07:53, Peter Chen wrote: > > On Mon, Jul 18, 2016 at 07:57:34AM +0200, Rafa=C5=82 Mi=C5=82ecki w= rote: > >> On 18 July 2016 at 07:40, Peter Chen wrote= : > >> > On Mon, Jul 18, 2016 at 06:44:49AM +0200, Rafa=C5=82 Mi=C5=82eck= i wrote: > >> >> On 18 July 2016 at 04:31, Peter Chen wr= ote: > >> >> > On Fri, Jul 15, 2016 at 11:10:45PM +0200, Rafa=C5=82 Mi=C5=82= ecki wrote: > >> >> >> + > >> >> >> +usbport trigger: > >> >> >> +- usb-ports : List of USB ports that usbport should observe= d for turning on a > >> >> >> + given LED. > >> >> >> + > >> >> > > >> >> > %s/should/should be > >> >> > >> >> Thanks. > >> >> > >> >> > >> >> >> diff --git a/drivers/leds/trigger/ledtrig-usbport.c b/driver= s/leds/trigger/ledtrig-usbport.c > >> >> >> new file mode 100644 > >> >> >> index 0000000..97b064c > >> >> >> --- /dev/null > >> >> >> +++ b/drivers/leds/trigger/ledtrig-usbport.c > >> >> >> @@ -0,0 +1,206 @@ > >> >> >> +/* > >> >> >> + * USB port LED trigger > >> >> >> + * > >> >> >> + * Copyright (C) 2016 Rafa=C5=82 Mi=C5=82ecki > >> >> >> + * > >> >> >> + * This program is free software; you can redistribute it a= nd/or modify > >> >> >> + * it under the terms of the GNU General Public License as = published by > >> >> >> + * the Free Software Foundation; either version 2 of the Li= cense, or (at > >> >> >> + * your option) any later version. > >> >> >> + */ > >> >> > > > > > In your COPYRIGHT, it says "or any later version". But afaik, It sh= ould > > not be on GPL v3. >=20 > If one picks my code, modifies it, relicenses it using GPL v3, we > can't include it anymore. It's the same story as with BSD systems and > their BSD licenses. If one picks e.g. BSD 3-clause licensed code, > makes it GPL, releases it (e.g. by putting in Linux), BSD can't use i= t > anymore. >=20 > Still, this license is GPL v2 compatible and as is it can be included > in the Linux. Anything GPLv2 compatible is fair game for the kernel. GPLv2+ is very common for the kernel. Best regards, Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses= /blog.html