Re: [PATCH v2 5/6] libfdt: Add fdt_setprop_inplace_namelen_partial

[David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1494 bytes --]

On Mon, Jul 18, 2016 at 03:45:58PM +0200, Maxime Ripard wrote:
> Hi David,
> 
> On Tue, Jul 12, 2016 at 09:45:20PM +1000, David Gibson wrote:
> > On Mon, Jul 11, 2016 at 09:56:22PM +0200, Maxime Ripard wrote:
> > > Add a function to modify inplace only a portion of a property..
> > > 
> > > This is especially useful when the property is an array of values, and you
> > > want to update one of them without changing the DT size.
> > > 
> > > Signed-off-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> > > Acked-by: Simon Glass <sjg-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org>
> > 
> > Reviewed-by: David Gibson <david-xT8FGy+AXnRB3Ne2BGzF6laj5H9X9Tb+@public.gmane.org>
> > 
> > Now it just needs some testcases..
> 
> Since fdt_setprop_inplace relies on it now, it already has some test
> coverage.
> 
> However, I tried to add some testcases for this to the test_tree1, but
> it was generating a lot of errors because it seems that not all tests
> are run from test_tree1.dts and generated by some other mean I
> couldn't identify. Could you point me to the right direction?

I'm not quite sure what you mean.

test_tree1 is generated in a number of different ways - these are
cross-compared at various points as part of the tests.

-- 
David Gibson			| I'll have my music baroque, and my code
david AT gibson.dropbear.id.au	| minimalist, thank you.  NOT _the_ _other_
				| _way_ _around_!
http://www.ozlabs.org/~dgibson

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]